Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routes.agency_id: add check #146

Open
AntoineAugusti opened this issue Oct 6, 2022 · 3 comments
Open

routes.agency_id: add check #146

AntoineAugusti opened this issue Oct 6, 2022 · 3 comments

Comments

@AntoineAugusti
Copy link
Member

This condition is not enforced at the moment.

Agency for the specified route. This field is required when the dataset provides data for routes from more than one agency in agency.txt, otherwise it is optional.

From routes.txt

@antoine-de
Copy link
Member

This could be related to rust-transit/gtfs-structure#126 since the typed ids would enforce all ids to be valid.

But there is still a bit of work on the PR and I'm not sure when i'll be able to work on it

@fchabouis
Copy link
Contributor

We could just add a check that if there are more than one agency, agency_id must be present. If not, we can outpout an Error.

@AntoineAugusti
Copy link
Member Author

@fchabouis What I had in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants