Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate --experimental-enable-distributed-tracing flag to feature gate #19050

Open
siyuanfoundation opened this issue Dec 12, 2024 · 3 comments · May be fixed by #19096
Open

migrate --experimental-enable-distributed-tracing flag to feature gate #19050

siyuanfoundation opened this issue Dec 12, 2024 · 3 comments · May be fixed by #19096
Assignees
@omerap12
Labels
help wanted type/feature

Comments

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Dec 12, 2024 •
edited
Loading

What would you like to be added?

Migrate --experimental-enable-distributed-tracing flag to use feature gate

Example for migrating an experimental flag: #19053
Also need to create new flags for this feature like --experimental-distributed-tracing-address -> --distributed-tracing-address and mark the old flag deprecated

Why is this needed?

part of #18023
@siyuanfoundation siyuanfoundation mentioned this issue Dec 12, 2024
Open
16 tasks
@siyuanfoundation siyuanfoundation changed the title Deprecate --experimental-enable-distributed-tracing flag to use feature gate migrate --experimental-enable-distributed-tracing flag to feature gate Dec 13, 2024
@omerap12
Copy link

/assign

@serathius
Copy link
Member

serathius commented Dec 19, 2024 •
edited
Loading

For distributed tracing I don't think we want to add a feature gate as the feature should stay optional in the future. I think we just want to migrate the flag off the --experimental prefix.

@omerap12
Copy link

For distributed tracing I don't think we want to add a feature gate as the feature should stay optional in the future. I think we just want to migrate the flag of the --experimental prefix.

Understood.

@omerap12 omerap12 linked a pull request Dec 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
help wanted type/feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate distributed tracing flags off experimental prefix omerap12/etcd
3 participants
@serathius @siyuanfoundation @omerap12