Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.1 Modal Crashes when pulling up replace with tag when deleting #5

Open
neokoenig opened this issue Dec 2, 2018 · 12 comments
Open

v1.0.1 Modal Crashes when pulling up replace with tag when deleting #5

neokoenig opened this issue Dec 2, 2018 · 12 comments

Comments

@neokoenig
Copy link

Steps to reproduce:

  • Select a Tag to Delete
  • Click Replace with Tag
  • Following Modal popup crashes

PHP version | 7.2.1
MySQL 5.6.26
GD 7.2.1
Craft Pro 3.0.33

Stack trace:

2018-12-02 14:08:05 [-][1][-][error][yii\web\HttpException:400] yii\web\BadRequestHttpException: ether\tagManager\Elements\Tag doesn’t exist or doesn’t extend/implement craft\base\ElementInterface in /srv/www/REDACTED/public/vendor/craftcms/cms/src/controllers/BaseElementsController.php:64
Stack trace:
#0 /srv/www/REDACTED/public/vendor/craftcms/cms/src/controllers/ElementsController.php(44): craft\controllers\BaseElementsController->elementType()
#1 [internal function]: craft\controllers\ElementsController->actionGetModalBody()
#2 /srv/www/REDACTED/public/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#3 /srv/www/REDACTED/public/vendor/yiisoft/yii2/base/Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#4 /srv/www/REDACTED/public/vendor/craftcms/cms/src/web/Controller.php(104): yii\base\Controller->runAction('get-modal-body', Array)
#5 /srv/www/REDACTED/public/vendor/yiisoft/yii2/base/Module.php(528): craft\web\Controller->runAction('get-modal-body', Array)
#6 /srv/www/REDACTED/public/vendor/craftcms/cms/src/web/Application.php(282): yii\base\Module->runAction('elements/get-mo...', Array)
#7 /srv/www/REDACTED/public/vendor/craftcms/cms/src/web/Application.php(542): craft\web\Application->runAction('elements/get-mo...', Array)
#8 /srv/www/REDACTED/public/vendor/craftcms/cms/src/web/Application.php(266): craft\web\Application->_processActionRequest(Object(craft\web\Request))
#9 /srv/www/REDACTED/public/vendor/yiisoft/yii2/base/Application.php(386): craft\web\Application->handleRequest(Object(craft\web\Request))
#10 /srv/www/REDACTED/public/web/index.php(21): yii\base\Application->run()
#11 {main}
2018-12-02 14:08:05 [-][1][-][info][application] $_GET = [
    'p' => 'admin/actions/elements/get-modal-body'
]

$_POST = [
    'context' => 'modal'
    'elementType' => 'ether\\tagManager\\Elements\\Tag'
    'sources' => ''
    'showSiteMenu' => '0'
]

$_FILES = []

$_COOKIE = [ etc]

$_SESSION = [ etc ]

$_SERVER = [
    'HTTP_HOST' => 'REDACTED'
    'HTTP_CONNECTION' => 'keep-alive'
    'CONTENT_LENGTH' => '85'
    'HTTP_ORIGIN' => 'http://REDACTED'
    'HTTP_X_CSRF_TOKEN' => 'REDACTED'
    'HTTP_X_REGISTERED_ASSET_BUNDLES' => ',ether\\tagManager\\web\\assets\\TagIndexAsset,craft\\web\\assets\\cp\\CpAsset,craft\\web\\assets\\d3\\D3Asset,craft\\web\\assets\\elementresizedetector\\ElementResizeDetectorAsset,craft\\web\\assets\\garnish\\GarnishAsset,yii\\web\\JqueryAsset,craft\\web\\assets\\jquerytouchevents\\JqueryTouchEventsAsset,craft\\web\\assets\\velocity\\VelocityAsset,craft\\web\\assets\\jqueryui\\JqueryUiAsset,craft\\web\\assets\\jquerypayment\\JqueryPaymentAsset,craft\\web\\assets\\datepickeri18n\\DatepickerI18nAsset,craft\\web\\assets\\picturefill\\PicturefillAsset,craft\\web\\assets\\selectize\\SelectizeAsset,craft\\web\\assets\\fileupload\\FileUploadAsset,craft\\web\\assets\\xregexp\\XregexpAsset,craft\\web\\assets\\fabric\\FabricAsset'
    'CONTENT_TYPE' => 'application/x-www-form-urlencoded; charset=UTF-8'
    'HTTP_X_REGISTERED_JS_FILES' => ',http://REDACTED/cpresources/987ca07f/d3.js?v=1543420452,http://REDACTED/cpresources/35e3175c/element-resize-detector.js?v=1543420452,http://REDACTED/cpresources/1a73bca9/jquery.js?v=1543420452,http://REDACTED/cpresources/917dbcec/jquery.mobile-events.min.js?v=1543420452,http://REDACTED/cpresources/bfc4bd4/velocity.js?v=1543420452,http://REDACTED/cpresources/abc1b7f9/garnish.js?v=1543420452,http://REDACTED/cpresources/4555d071/jquery-ui.min.js?v=1543420452,http://REDACTED/cpresources/17dbe43c/jquery.payment.js?v=1543420452,http://REDACTED/cpresources/db040ab6/datepicker-en-GB.js?v=1543420458,http://REDACTED/cpresources/96d9802e/picturefill.js?v=1543420452,http://REDACTED/cpresources/c2a7adaa/selectize.js?v=1543420452,http://REDACTED/cpresources/8e3181d0/jquery.fileupload.js?v=1543420452,http://REDACTED/cpresources/c8cbe920/xregexp-all.js?v=1543420452,http://REDACTED/cpresources/be8763c7/fabric.js?v=1543420452,http://REDACTED/cpresources/c48888e3/js/Craft.min.js?v=1543420452,http://REDACTED/cpresources/791fef67/TagIndex.js?v=1543759600'
    'HTTP_ACCEPT' => 'application/json, text/javascript, */*; q=0.01'
    'HTTP_X_REQUESTED_WITH' => 'XMLHttpRequest'
    'HTTP_USER_AGENT' => 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36'
    'HTTP_DNT' => '1'
    'HTTP_REFERER' => 'http://REDACTED/admin/tags'
    'HTTP_ACCEPT_ENCODING' => 'gzip, deflate'
    'HTTP_ACCEPT_LANGUAGE' => 'en-US,en;q=0.9'
    'HTTP_COOKIE' => 'REDACTED'
    'PATH' => '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
    'SERVER_SIGNATURE' => ''
    'SERVER_SOFTWARE' => 'Apache'
    'SERVER_NAME' => 'REDACTED'
    'SERVER_ADDR' => 'REDACTED'
    'SERVER_PORT' => '80'
    'REMOTE_ADDR' => 'REDACTED'
    'DOCUMENT_ROOT' => '/srv/www/REDACTED/public/web/'
    'REQUEST_SCHEME' => 'http'
    'CONTEXT_PREFIX' => ''
    'CONTEXT_DOCUMENT_ROOT' => '/srv/www/REDACTED/public/web/'
    'SERVER_ADMIN' => 'webmaster@REDACTED'
    'SCRIPT_FILENAME' => '/srv/www/REDACTED/public/web/index.php'
    'REMOTE_PORT' => '60799'
    'GATEWAY_INTERFACE' => 'CGI/1.1'
    'SERVER_PROTOCOL' => 'HTTP/1.1'
    'REQUEST_METHOD' => 'POST'
    'QUERY_STRING' => 'p=admin/actions/elements/get-modal-body'
    'REQUEST_URI' => '/index.php?p=admin/actions/elements/get-modal-body'
    'SCRIPT_NAME' => '/index.php'
    'PHP_SELF' => '/index.php'
    'REQUEST_TIME_FLOAT' => 1543759685.571
    'REQUEST_TIME' => 1543759685
    'ENVIRONMENT' => 'staging'
    'SECURITY_KEY' => 'REDACTED'
    'DB_DRIVER' => 'mysql'
    'DB_SERVER' => 'localhost'
    'DB_USER' => 'REDACTED'
    'DB_PASSWORD' => 'REDACTED'
    'DB_DATABASE' => 'REDACTED'
    'DB_SCHEMA' => 'public'
    'DB_TABLE_PREFIX' => ''
    'DB_PORT' => '3306'
]
@jwmatlock
Copy link

Experiencing the same issue with Craft CMS 3.0.25.

@auralon
Copy link

auralon commented Feb 11, 2019

Experiencing the same issue with Craft CMS 3.0.40 too.

@mafu-d
Copy link

mafu-d commented Feb 28, 2019

Same here, on Craft CMS 3.0.37.

@migplay
Copy link

migplay commented Mar 27, 2019

Same bug with Craft CMS 3.1.19

@Tam
Copy link
Member

Tam commented Apr 3, 2019

Do you have any other plugins installed? I've just tested on a fresh Craft install (3.1.20.1) without issue.

@migplay
Copy link

migplay commented Apr 3, 2019 via email

@Tam
Copy link
Member

Tam commented Apr 3, 2019

@migswd A list of the other plugins you're using. It's likely that one is interfering with Tags in some way which is causing the issue.

@migplay
Copy link

migplay commented Apr 3, 2019 via email •
edited by Tam
Loading

@jurriaanr
Copy link

jurriaanr commented Apr 25, 2019 •
edited
Loading

@Tam I have the same issue. I compared my plugins with the ones above and the there are 3 overlapping. One of them is Embedded Assets, which i disabled. That fixed the problem. I do need the embedded assets plugin, so a fix would be great!

On a side note - and I can make a separate issue if you wish. When editing a single tag and deleting it, the replace window is not triggered and the tag is removed as is. I would expect the same functionality there.

@Tam
Copy link
Member

Tam commented May 9, 2019

I can't recreate the issue with the Embedded Assets plugin, it's possible they pushed a release that fixed it. Is it still an issue for you?

@jurriaanr I've just released 1.0.3 which adds the replace modal to the edit page delete action.

@svale svale mentioned this issue May 31, 2019
Merged
@jurriaanr
Copy link

The problems seems to have been partly solved. There is no longer a crash and I get the popup. However, in the popup the All Tags option does not show any tags, nor can I actually select a tag

Tags

@mattandrews
Copy link

I'm experiencing this issue too and don't have the Embedded Assets plugin installed. Here are my plugins:

Amazon S3	        1.1.3
Control Panel CSS	2.1.0
Control Panel JS	2.1.0
Element API	        2.5.4
Element Map	        1.2.1
Inventory               2.0.2
Preview Button          1.0.3
Recentchanges           1.1.2
Redactor                2.3.1
Super Table	        2.1.8
Tags	                1.0.1

Using Craft Pro 3.1.12 and I haven't tried v1.0.3 suggested here yet (since it sounds like it doesn't fix the issue?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jwmatlock @neokoenig @mattandrews @Tam @migplay @jurriaanr @auralon @mafu-d