Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run portal-hive tests directly against local binary of the client #105

Open
kdeme opened this issue Sep 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kdeme
Copy link
Collaborator

kdeme commented Sep 19, 2023

When working on portal-hive failures that are related to a client, currently we need to rebuild the client its docker image.
How long this takes, does depend on the implementation of the Dockerfile for the client, but will always take more than then just building it locally, which you usually would do anyhow when testing.

It would be nice if we had some special debugging runner that could run the tests from a provided local binary.

This is not a crucial nor urgent feature, but it does seem there is some interest for this at least.

@kdeme kdeme added the enhancement New feature or request label Sep 19, 2023
@fjl
Copy link
Contributor

fjl commented Feb 10, 2024

We have solved this problem in upstream hive by providing a Dockerfile.local for some clients. Hive can be made to use this file by way of the --client-file option. Since the portal simulators have already been moved to upstream hive, you can use this now if you send a PR with a working Dockerfile.local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants