Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test matching pattern in hivesim-rs #30

Open
ogenev opened this issue Apr 23, 2023 · 6 comments
Open

Implement test matching pattern in hivesim-rs #30

ogenev opened this issue Apr 23, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@ogenev
Copy link
Member

ogenev commented Apr 23, 2023

Running and matching on a specific portal hive test helps us with local development and debugging.

Example implementation in GO: https://github.com/ethereum/portal-hive/blob/main/hivesim/testmatch.go

@ogenev
Copy link
Member Author

ogenev commented Apr 28, 2023

@dhavall13 Could you open a PR with the proposed change and we can review/discuss it there?

@Aditya-Sood
Copy link

hi @ogenev
is this issue still open for contribution?

@ogenev
Copy link
Member Author

ogenev commented Aug 14, 2023

hi @ogenev is this issue still open for contribution?

yes, it is open.

@Aditya-Sood
Copy link

could you please explain the scope of the issue and assign it?
thank you

@ogenev
Copy link
Member Author

ogenev commented Aug 21, 2023

could you please explain the scope of the issue and assign it? thank you

We want a functionality to match a test to a regex pattern. The idea is to use hive
--sim.limit <pattern> cli to specify a regular expression to selectively enable suites and test cases. This is interpreted by simulators and it sets the HIVE_TEST_PATTERN environment variable.

Right now, hivesim-rs don't use this functionality because a test matcher is not implemented.

@Aditya-Sood
Copy link

hi @ogenev, I didn't realise that this is not a ticket for the go implementation
I haven't worked with rust before so wouldn't be able to contribute to this

if anyone else can assist with the issue, kindly do so
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants