List of tests that need to be written

[pipermerriam]

Let's add things to this list:

• rpc-compat:
  • portal_historyFindNodes (See that there was an incompatibility in trin. This checkbox replaces the issue: Add portal-hive rpc-interop test for portal_historyFindNodes trin#704 )

[ogenev]

Do we have a list of tests that need to be written?

We don't have a list right now, @KolbyML is doing a great job to implement any missing single client/two client scenario test following the JSON-RPC specs.

However, I think it is wise to have such a list especially when we switch to more complicated tests (3 and more clients).

If you have any suggestions, please write them here and we can start keeping a test list in this issue.

[KolbyML]

I can start a issue for that. Since I seem to be the main person right now on the "writing test force". There are so many tests that can be written. Especially when it comes to writing tests for scenarios since I think that is where tests will really display edge cases. So I get what @ogenev is talking about when he says 3+. For 3 client tests I believe we will get a new simulator. Since I don't think it makes sense to add those to portal-interop. So it could be a good idea to split/refactor it into "portal-interop 2 clients" then a 3 clients one.

Edit: I just read ogenev suggested we keep a test list in this I agree

[carver]

Idle thought, something to add to the list of tests (portal-interop I think), if it's not already tested: retrieving receipts when there are none for a block. It would be easy for a client to mix up an empty list returned with no response, so we need to test that the two cases (no peers have the receipts available, and a peer returned the empty list of receipts) are distinguishable and returned correctly.

[carver]

I guess no one has made this list. I'll just start adding things into the body of this issue.

[KolbyML]

@carver rpc-compat tests 1 node rpc's doesn't portal_historyFindNodes require 2 nodes? Also isn't what you are specifing already being tested? Maybe I am confused on what you meant.