Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Behavior with clear_foreign_voxels: true After Map Loading #77

Open
KuangHaofei opened this issue Dec 20, 2024 · 0 comments
Open

Comments

@KuangHaofei
Copy link

Hi @Schmluk,

Thanks for your great work!

When I applied your method in my scenario, I enabled clear_foreign_voxels: true due to segmentation errors in some complex scenes. This setting helped remove many outliers from the mesh, as shown in this example (see attached image for details, it generate a clean wall where most of the spurious voxels are cleared):
Screenshot from 2024-12-20 10-40-20

However, after saving and then loading the .panmap file, the outliers reappeared in the mesh (see the attached image).

Screenshot from 2024-12-20 10-42-38

Upon reviewing the code, I noticed the following:

  1. When clear_foreign_voxels: true, only the mesh generation process removes outliers based on the class layer. Other layers, such as the TSDF layers, remain unchanged. This can be observed in this part of the code:
    Relevant code snippet

  2. During a subsequent run, when loading the saved map, the previously initialized class layer seems to be ignored in the mesh generation process, as seen here:
    Relevant code snippet

As a result, the mesh still contains outliers after loading the map.

To address this issue, I have two questions:

  1. How can I update the other layers (e.g., TSDF layer or TSDF blocks) when outliers are removed using the clear_foreign_voxels option?
  2. How can I ensure the initialized class layer is used during mesh generation after loading the map?

If there are alternative approaches or recommendations, I’d be happy to hear your suggestions.

Thanks in advance for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant