Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy warnings about untyped functions #2

Open
Mr-Geekman opened this issue Aug 14, 2023 · 1 comment
Open

Fix mypy warnings about untyped functions #2

Mr-Geekman opened this issue Aug 14, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Mr-Geekman
Copy link

Issue by Mr-Geekman
Monday Jul 24, 2023 at 06:40 GMT
Originally opened as tinkoff-ai#1327


🚀 Feature Request

Fix mypy warnings about untyped functions, because now it shows warnings like:

etna/transforms/decomposition/change_points_based/per_interval_models/constant.py:13: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

Proposal

  • Fix warnings
  • Try to add option disallow-untyped-defs
    • It there aren't too many errors fix them and keep this option

Test cases

No response

Additional context

Developing in docs-prototype branch.

@Mr-Geekman Mr-Geekman added documentation Improvements or additions to documentation enhancement New feature or request priority/medium Medium priority task labels Aug 14, 2023
@Mr-Geekman
Copy link
Author

Comment by Mr-Geekman
Thursday Jul 27, 2023 at 13:31 GMT


Setting disallow_untyped_defs = true in pyproject.toml gives:

Found 358 errors in 99 files (checked 195 source files)

So, this issue requires a lot of changes. However, most of that I've seen is very simple.

@Mr-Geekman Mr-Geekman added this to the Documentation rework milestone Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Todo in etna board Aug 15, 2023
@d-a-bunin d-a-bunin removed this from the Documentation rework milestone Sep 1, 2023
@d-a-bunin d-a-bunin added priority/low Low priority task and removed priority/medium Medium priority task labels Mar 26, 2024
@Polzovat123 Polzovat123 moved this from Todo to In Progress in etna board Apr 1, 2024
@Polzovat123 Polzovat123 moved this from In Progress to Todo in etna board Apr 1, 2024
@d-a-bunin d-a-bunin removed the priority/low Low priority task label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants