Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregation method parameter to Imputers #21

Closed
Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Closed

Add aggregation method parameter to Imputers #21

Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Mr-Geekman
Copy link

Issue by alex-hse-repository
Friday Nov 25, 2022 at 15:04 GMT
Originally opened as tinkoff-ai#1015


🚀 Feature Request

Add possibility to perform different kids of aggregation for seasonal strategy in TimeSeriesImputerTransform

Proposal

  1. In TimeSeriesImputerTransform add parameter aggregation_method: AggregationMode = "AggregationMode.mean -- method to aggregate values in the window (see link)
  2. Update method _fill to handle the logic with aggregation_method -- now it should aggregate values according the the passed method
    https://github.com/tinkoff-ai/etna/blob/cfbfb01d28fd330ca42de7a7176384708174920d/etna/transforms/missing_values/imputation.py#L203
  3. Update the docs

Test cases

Add test for the seasonal strategy which checks that it works correctly with different aggregation_method

Additional context

No response

@Mr-Geekman Mr-Geekman added DKO enhancement New feature or request labels Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Specification in etna board Aug 15, 2023
@d-a-bunin d-a-bunin removed the DKO label Mar 26, 2024
@etna-team etna-team locked and limited conversation to collaborators May 29, 2024
@d-a-bunin d-a-bunin converted this issue into discussion #349 May 29, 2024
@github-project-automation github-project-automation bot moved this from Specification to Done in etna board May 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants