Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested: CharacterSet Auto Selector #222

Open
designe opened this issue Sep 4, 2022 Discussed in #221 · 0 comments
Open

Suggested: CharacterSet Auto Selector #222

designe opened this issue Sep 4, 2022 Discussed in #221 · 0 comments
Assignees
@DahyeonWoo
Labels
Feature Proposal Anything about happy development! from discussions this issue is made from discussions osca-22 Contribution From Open Source Academy 2022

Comments

@designe
Copy link
Member

designe commented Sep 4, 2022

Discussed in https://github.com/orgs/euphony-io/discussions/221

Originally posted by DahyeonWoo September 4, 2022
Hello, I am planning to make CharacterSet Auto Selector.

File

euphony/euphony/src/main/cpp/core/charset

  • CharsetAutoSelector.h
  • CharsetAutoSelector.cpp
  • README.md

euphony/euphony/src/main/cpp/tests/charset

  • CharsetAutoSelectorTest.cpp

Is there another name? 😀

Input & Output

  • Input: desired String value
  • Output: Return the charset showing the shortest encoding result (Charset interface)

Unit Test

  • gtest

Docs

  • Charset, ASCII, UTF, UNICODE
    • DefaultCharset, ASCIICharset, UTF-8, UTF-16, UTF-32
@designe designe added the Feature Proposal Anything about happy development! label Sep 4, 2022
DahyeonWoo added a commit to DahyeonWoo/euphony that referenced this issue Sep 11, 2022
@DahyeonWoo
Add CharsetAutoSelector (euphony-io#222)
5775a70
DahyeonWoo added a commit to DahyeonWoo/euphony that referenced this issue Sep 12, 2022
@DahyeonWoo
Fix sort logic (euphony-io#222)
fb31718
@DahyeonWoo DahyeonWoo mentioned this issue Sep 12, 2022
Closed
@yeonns yeonns linked a pull request Sep 12, 2022 that will close this issue
Add CharsetAutoSelector (#222) #245
Closed
DahyeonWoo added a commit to DahyeonWoo/euphony that referenced this issue Sep 12, 2022
@DahyeonWoo
Fix variable name (euphony-io#222)
7e93232
DahyeonWoo added a commit to DahyeonWoo/euphony that referenced this issue Sep 17, 2022
@DahyeonWoo
Fix object (euphony-io#222)
1a907b9
@designe designe added from discussions this issue is made from discussions osca-22 Contribution From Open Source Academy 2022 labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DahyeonWoo DahyeonWoo

Labels
Feature Proposal Anything about happy development! from discussions this issue is made from discussions osca-22 Contribution From Open Source Academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CharsetAutoSelector (#222) DahyeonWoo/euphony
2 participants
@designe @DahyeonWoo