Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "mash to enable" independent of CmdrClient:SetEnabled #298

Open
autonordev opened this issue Aug 26, 2023 · 0 comments
Open

Make "mash to enable" independent of CmdrClient:SetEnabled #298

autonordev opened this issue Aug 26, 2023 · 0 comments
Labels

Comments

@autonordev
Copy link
Collaborator

Currently, the mash to enable feature will override any developer-made calls to CmdrClient:SetEnabled. For instance, to disable the console. Enabling the mash to open feature will also disable the console. Similarly, any calls to SetEnabled after SetMashToEnable is called will override mash to enable (i.e. calling SetEnabled(true) will bypass mash to enable, calling SetEnabled(false) will require mashing before the console re-opens).

This could be a problem for games which use CmdrClient:SetEnabled to restrict console access, but which also use mash to enable to avoid accidental console opening.

While this does not break any API contracts, it does change behaviour, so we should be mindful about developer and user needs here. We don't need to take any special steps to notify developers of this change in behaviour aside from a clear bullet in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant