New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gem interface #20

Open

gbp opened this issue Oct 25, 2018 · 0 comments

Labels

Contributor

gbp commented Oct 25, 2018

The gem requires existing statements and suggestion in a certain format. This leads to strange case where we're doing things like

membership-comparison/spec/membership_comparison_spec.rb

Line 48 in f367ee5

    
           'wds:1030-1DAA-3102' => { position: mp, term: { id: nil }, party: { id: nil }, district: { id: nil } },

.

It would be better to change the interface to not use nested hashes. This would work well with how the data is returned from the query service and would potential mean we wouldn't need to map the query result into the format expected here: https://github.com/mysociety/verification-pages/blob/master/app/services/new_statement_classifier.rb#L140-L155

gbp added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment