Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to CSS Custom Properties for dynamic styles #12

Open
ai opened this issue Aug 16, 2023 · 0 comments
Open

Move to CSS Custom Properties for dynamic styles #12

ai opened this issue Aug 16, 2023 · 0 comments

Comments

@ai
Copy link
Member

ai commented Aug 16, 2023

Reasons:

  1. Inline CSS has worse performance (because their changes re-build CSSOM)
  2. A better separation. All styles will be in Tailwind (I think you could use CSS Custom Properties colors in Tailwind config)
  3. Often you use the same color in two places (like top and bottom use label color). With CSS Custom Properties they both can share the same token.
  4. Very likely that you will be able to remove <ColorMetrics>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ai