Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kills done while in a vehicle arn't tracked #219

Open
Cooldude2606 opened this issue Aug 14, 2021 · 5 comments
Open

Kills done while in a vehicle arn't tracked #219

Cooldude2606 opened this issue Aug 14, 2021 · 5 comments
Labels
Bug Reporting/fixing a bug, error, or desync

Comments

@Cooldude2606
Copy link
Member

Factorio version
Version number: 1.1.37

Scenario version
Version number: 6.2.0

Bug description
The datastore statistics for player kills are not increased when the player is in a vehicle. The issue is because the filter during on_entity_died is too restrictive. There is a good chance that this issue also effects the on_entity_damaged event as this uses a similar filter.

Reproduction method
Steps to reproduce the behavior:

  1. Get in any vehicle, such as a spidertron.
  2. Kill biters.
  3. Counter does not increase

Expected behavior
The counter should track all player kills.

@Cooldude2606 Cooldude2606 added the Bug Reporting/fixing a bug, error, or desync label Aug 14, 2021
@PHIDIAS0303
Copy link
Contributor

The counter should track the kills if the player is in the vehicle.
But auto defence by spidertron or what should not be counted?

@Cooldude2606
Copy link
Member Author

Auto kills will need to be ignored, I am unaware of any simple way to relate these kills back to a player beyond keeping an index of who and when remotes were used. As such I believe updating the filter to include vehicles with players in them will be a sufficient fix.

@PHIDIAS0303
Copy link
Contributor

the only thing not sure about is artillery remote kills but it may be better not to include it in this update.

@Cooldude2606
Copy link
Member Author

Should artillery even be counted? It less of the player killing things and more just the player asking for stuff to be killed.

@PHIDIAS0303
Copy link
Contributor

other than checking for character type it can check for vehicles as well.
when there is a driver or passenger it should be counted as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reporting/fixing a bug, error, or desync
Projects
None yet
Development

No branches or pull requests

2 participants