Slice.submit() duplicates Slice.modify()

[sajith]

Slice.submit() does this:

fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py

Lines 1964 to 1970 in 8f698c6

	if self._is_modify():
	(
	return_status,
	slice_reservations,
	) = self.fablib_manager.get_slice_manager().modify(
	slice_id=self.slice_id, slice_graph=slice_graph
	)

But Slice.modify() also does that:

fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py

Lines 2479 to 2484 in 8f698c6

	(
	return_status,
	slice_reservations,
	) = self.fablib_manager.get_slice_manager().modify(
	slice_id=self.slice_id, slice_graph=slice_graph
	)

One difference between them is that, since #264, Slice.submit() does the extra work of re-running post-boot scripts on modify. (There could be other differences as well; I haven't checked thoroughly.)

Both methods performing roughly equivalent action could be a source of confusion. What are our options here?

• Refactor common code, or
• Remove modify(), and use submit() instead, or
• Document the difference between them, or
• Do nothing?