Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit hooks #22

Open
azizi-a opened this issue Oct 2, 2020 · 0 comments
Open

Pre-commit hooks #22

azizi-a opened this issue Oct 2, 2020 · 0 comments
Labels
code review compliment enhancement New feature or request

Comments

@azizi-a
Copy link

azizi-a commented Oct 2, 2020 •
edited
Loading

Nice use of pre-commit hooks. I see there's a git add . there to make sure the hook changes are staged.
Suggestion: You may want to use lint-staged for your pre commit hooks, instead of the extra git add . as it will only stage already staged files that have been changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review compliment enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azizi-a