From d09c043c178b197eb653b1653a7fc4f6245eb5ec Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Fri, 17 May 2024 16:09:38 -0700 Subject: [PATCH] Remove unused variables in fbmeshd/rnl/tests/NetlinkSocketTest.cpp (#2405) Summary: Pull Request resolved: https://github.com/facebookresearch/fbpcs/pull/2405 LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D57344008 fbshipit-source-id: b5f906e2d4c922590286ab5ecd4df12a3e070075 --- fbpcs/emp_games/dotproduct/DotproductApp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fbpcs/emp_games/dotproduct/DotproductApp.h b/fbpcs/emp_games/dotproduct/DotproductApp.h index a8b2bc590..cd5fa4c43 100644 --- a/fbpcs/emp_games/dotproduct/DotproductApp.h +++ b/fbpcs/emp_games/dotproduct/DotproductApp.h @@ -109,7 +109,7 @@ class DotproductApp { std::vector> allLabels; auto lineNo = 0; - bool success = private_measurement::csv::readCsv( + private_measurement::csv::readCsv( inputPath, [&](const std::vector& header, const std::vector& parts) {