From 90cff2375a0dc281dc54e510f16d18e6ca26946b Mon Sep 17 00:00:00 2001 From: Nicholas Ormrod Date: Wed, 20 Nov 2024 11:43:13 -0800 Subject: [PATCH] facebook-unused-include-check in fbcode/fbpcs/data_processing Summary: Remove headers flagged by facebook-unused-include-check over fbcode.fbpcs.data_processing. + format and autodeps This is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle. You have been added as a reviewer by Sentinel or Butterfly. Autodiff project: uif Autodiff partition: fbcode.fbpcs.data_processing Autodiff bookmark: ad.uif.fbcode.fbpcs.data_processing Differential Revision: D65957914 --- .../attribution_id_combiner/AttributionIdSpineCombiner.cpp | 4 ---- .../AttributionIdSpineFileCombinerTest.cpp | 3 --- .../attribution_id_combiner/MrPidAttributionIdCombiner.cpp | 7 ------- .../MrPidAttributionIdCombinerTest.cpp | 3 --- .../attribution_id_combiner/PidAttributionIdCombiner.cpp | 4 ---- .../PidAttributionIdCombinerTest.cpp | 4 ---- fbpcs/data_processing/lift_id_combiner/LiftStrategy.cpp | 1 - .../lift_id_combiner/MrPidLiftIdCombiner.cpp | 4 ---- .../lift_id_combiner/MrPidLiftIdCombinerTest.cpp | 2 -- .../data_processing/lift_id_combiner/PidLiftIdCombiner.cpp | 7 ------- .../lift_id_combiner/PidLiftIdCombinerTest.cpp | 2 -- .../lift_id_combiner/test/LiftIdSpineFileCombinerTest.cpp | 1 - .../data_processing/pid_preparer/UnionPIDDataPreparer.cpp | 2 -- .../MrPidPrivateIdDfcaIdCombiner.cpp | 7 ------- .../PidPrivateIdDfcaIdCombiner.cpp | 4 ---- .../PrivateIdDfcaIdSpineCombiner.cpp | 3 --- .../PrivateIdDfcaIdSpineFileCombinerTest.cpp | 3 --- .../private_id_dfca_id_combiner/PrivateIdDfcaStrategy.cpp | 2 -- fbpcs/data_processing/sharding/GenericSharder.cpp | 2 -- fbpcs/data_processing/sharding/HashBasedSharder.cpp | 6 ------ fbpcs/data_processing/sharding/Sharding.cpp | 4 ---- 21 files changed, 75 deletions(-) diff --git a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombiner.cpp b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombiner.cpp index 437d71802..9b4984db6 100644 --- a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombiner.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombiner.cpp @@ -20,12 +20,8 @@ #include #include "fbpcf/io/api/BufferedReader.h" -#include "fbpcf/io/api/FileIOWrappers.h" -#include "fbpcf/io/api/FileReader.h" #include "fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombinerOptions.h" -#include "fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombinerUtil.h" #include "fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombiner.h" -#include "fbpcs/data_processing/common/FilepathHelpers.h" int main(int argc, char** argv) { folly::init(&argc, &argv); diff --git a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp index 70aa8ea94..1c3196e06 100644 --- a/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineFileCombinerTest.cpp @@ -7,12 +7,9 @@ #include "AttributionIdSpineFileCombiner.h" -#include #include -#include #include -#include #include #include diff --git a/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombiner.cpp b/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombiner.cpp index 1e1216591..97388371f 100644 --- a/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombiner.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombiner.cpp @@ -9,15 +9,8 @@ #include #include -#include #include -#include -#include #include -#include -#include - -#include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" namespace pid::combiner { MrPidAttributionIdCombiner::MrPidAttributionIdCombiner() diff --git a/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombinerTest.cpp b/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombinerTest.cpp index d5e16a075..943b6bef3 100644 --- a/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombinerTest.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombinerTest.cpp @@ -8,11 +8,8 @@ #include "fbpcs/data_processing/attribution_id_combiner/MrPidAttributionIdCombiner.h" #include -#include #include -#include #include -#include #include #include "fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombinerOptions.h" diff --git a/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.cpp b/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.cpp index e23c85979..bfd4f8564 100644 --- a/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.cpp @@ -7,13 +7,9 @@ #include "fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.h" -#include #include #include -#include #include -#include -#include #include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" diff --git a/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombinerTest.cpp b/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombinerTest.cpp index fd3e528b3..820c1f7e8 100644 --- a/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombinerTest.cpp +++ b/fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombinerTest.cpp @@ -8,14 +8,10 @@ #include "fbpcs/data_processing/attribution_id_combiner/PidAttributionIdCombiner.h" #include -#include #include -#include #include -#include #include -#include "fbpcf/io/api/FileIOWrappers.h" #include "fbpcs/data_processing/attribution_id_combiner/AttributionIdSpineCombinerOptions.h" #include "fbpcs/data_processing/test_utils/FileIOTestUtils.h" diff --git a/fbpcs/data_processing/lift_id_combiner/LiftStrategy.cpp b/fbpcs/data_processing/lift_id_combiner/LiftStrategy.cpp index b01310bb1..aaac55b30 100644 --- a/fbpcs/data_processing/lift_id_combiner/LiftStrategy.cpp +++ b/fbpcs/data_processing/lift_id_combiner/LiftStrategy.cpp @@ -15,7 +15,6 @@ #include "fbpcs/data_processing/id_combiner/DataPreparationHelpers.h" #include "fbpcs/data_processing/id_combiner/DataValidation.h" #include "fbpcs/data_processing/id_combiner/GroupBy.h" -#include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" #include "fbpcs/data_processing/id_combiner/SortIds.h" #include "fbpcs/data_processing/id_combiner/SortIntegralValues.h" #include "fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombinerOptions.h" diff --git a/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombiner.cpp b/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombiner.cpp index ab1b3d27f..71e29be3e 100644 --- a/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombiner.cpp +++ b/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombiner.cpp @@ -11,8 +11,6 @@ #include #include #include -#include -#include #include #include #include @@ -22,9 +20,7 @@ #include #include "fbpcf/io/api/BufferedReader.h" -#include "fbpcf/io/api/FileIOWrappers.h" #include "fbpcf/io/api/FileReader.h" -#include "fbpcs/data_processing/common/FilepathHelpers.h" #include "fbpcs/data_processing/id_combiner/DataPreparationHelpers.h" #include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" #include "fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombinerOptions.h" diff --git a/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombinerTest.cpp b/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombinerTest.cpp index da9e1f148..ed95cb324 100644 --- a/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombinerTest.cpp +++ b/fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombinerTest.cpp @@ -8,11 +8,9 @@ #include "fbpcs/data_processing/lift_id_combiner/MrPidLiftIdCombiner.h" #include -#include #include #include #include -#include #include #include "fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombinerOptions.h" diff --git a/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.cpp b/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.cpp index fc924ed55..bd6aff462 100644 --- a/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.cpp +++ b/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.cpp @@ -8,23 +8,16 @@ #include "fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.h" #include -#include #include -#include #include #include #include -#include #include -#include #include #include "fbpcf/io/api/BufferedReader.h" #include "fbpcf/io/api/FileReader.h" -#include "fbpcs/data_processing/common/FilepathHelpers.h" -#include "fbpcs/data_processing/id_combiner/DataPreparationHelpers.h" #include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" -#include "fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombinerOptions.h" namespace pid::combiner { PidLiftIdCombiner::PidLiftIdCombiner( diff --git a/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombinerTest.cpp b/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombinerTest.cpp index e159cc0be..c01b3956c 100644 --- a/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombinerTest.cpp +++ b/fbpcs/data_processing/lift_id_combiner/PidLiftIdCombinerTest.cpp @@ -8,11 +8,9 @@ #include "fbpcs/data_processing/lift_id_combiner/PidLiftIdCombiner.h" #include -#include #include #include #include -#include #include #include "fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombinerOptions.h" diff --git a/fbpcs/data_processing/lift_id_combiner/test/LiftIdSpineFileCombinerTest.cpp b/fbpcs/data_processing/lift_id_combiner/test/LiftIdSpineFileCombinerTest.cpp index 32d36b4ca..0c8ea2a44 100644 --- a/fbpcs/data_processing/lift_id_combiner/test/LiftIdSpineFileCombinerTest.cpp +++ b/fbpcs/data_processing/lift_id_combiner/test/LiftIdSpineFileCombinerTest.cpp @@ -12,7 +12,6 @@ #include #include "fbpcs/data_processing/test_utils/FileIOTestUtils.h" -#include #include using namespace ::pid::combiner; diff --git a/fbpcs/data_processing/pid_preparer/UnionPIDDataPreparer.cpp b/fbpcs/data_processing/pid_preparer/UnionPIDDataPreparer.cpp index fae0409d5..0ab608d6d 100644 --- a/fbpcs/data_processing/pid_preparer/UnionPIDDataPreparer.cpp +++ b/fbpcs/data_processing/pid_preparer/UnionPIDDataPreparer.cpp @@ -11,11 +11,9 @@ #include #include #include -#include #include #include #include -#include #include #include #include diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/MrPidPrivateIdDfcaIdCombiner.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/MrPidPrivateIdDfcaIdCombiner.cpp index 5e96ebde9..31a3fc574 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/MrPidPrivateIdDfcaIdCombiner.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/MrPidPrivateIdDfcaIdCombiner.cpp @@ -9,15 +9,8 @@ #include #include -#include #include -#include -#include #include -#include -#include - -#include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" namespace pid::combiner { MrPidPrivateIdDfcaIdCombiner::MrPidPrivateIdDfcaIdCombiner() diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/PidPrivateIdDfcaIdCombiner.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/PidPrivateIdDfcaIdCombiner.cpp index 853a92532..107da041b 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/PidPrivateIdDfcaIdCombiner.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/PidPrivateIdDfcaIdCombiner.cpp @@ -7,13 +7,9 @@ #include "fbpcs/data_processing/private_id_dfca_id_combiner/PidPrivateIdDfcaIdCombiner.h" -#include #include #include -#include #include -#include -#include #include "fbpcs/data_processing/id_combiner/IdSwapMultiKey.h" diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineCombiner.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineCombiner.cpp index 464ae6200..f9da4aa1c 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineCombiner.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineCombiner.cpp @@ -20,9 +20,6 @@ #include #include "fbpcf/io/api/BufferedReader.h" -#include "fbpcf/io/api/FileIOWrappers.h" -#include "fbpcf/io/api/FileReader.h" -#include "fbpcs/data_processing/common/FilepathHelpers.h" #include "fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineCombinerOptions.h" #include "fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombiner.h" diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp index 87053c7a9..31959fab2 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombinerTest.cpp @@ -7,12 +7,9 @@ #include "fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaIdSpineFileCombiner.h" -#include #include -#include #include -#include #include #include diff --git a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaStrategy.cpp b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaStrategy.cpp index 3df7c9f67..8aabbb82f 100644 --- a/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaStrategy.cpp +++ b/fbpcs/data_processing/private_id_dfca_id_combiner/PrivateIdDfcaStrategy.cpp @@ -13,10 +13,8 @@ #include #include "fbpcf/io/api/FileIOWrappers.h" #include "fbpcs/data_processing/common/FilepathHelpers.h" -#include "fbpcs/data_processing/id_combiner/AddPaddingToCols.h" #include "fbpcs/data_processing/id_combiner/DataPreparationHelpers.h" #include "fbpcs/data_processing/id_combiner/DataValidation.h" -#include "fbpcs/data_processing/id_combiner/GroupBy.h" #include "fbpcs/data_processing/id_combiner/SortIds.h" namespace pid::combiner { diff --git a/fbpcs/data_processing/sharding/GenericSharder.cpp b/fbpcs/data_processing/sharding/GenericSharder.cpp index 1b6c5f103..147032d3b 100644 --- a/fbpcs/data_processing/sharding/GenericSharder.cpp +++ b/fbpcs/data_processing/sharding/GenericSharder.cpp @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -31,7 +30,6 @@ #include #include -#include "fbpcs/data_processing/common/FilepathHelpers.h" #include "fbpcs/data_processing/common/Logging.h" #include "folly/String.h" diff --git a/fbpcs/data_processing/sharding/HashBasedSharder.cpp b/fbpcs/data_processing/sharding/HashBasedSharder.cpp index 580624cc8..75048bc01 100644 --- a/fbpcs/data_processing/sharding/HashBasedSharder.cpp +++ b/fbpcs/data_processing/sharding/HashBasedSharder.cpp @@ -7,14 +7,8 @@ #include "fbpcs/data_processing/sharding/HashBasedSharder.h" -#include - -#include #include -#include #include -#include -#include #include #include diff --git a/fbpcs/data_processing/sharding/Sharding.cpp b/fbpcs/data_processing/sharding/Sharding.cpp index b221dbb24..6737528b3 100644 --- a/fbpcs/data_processing/sharding/Sharding.cpp +++ b/fbpcs/data_processing/sharding/Sharding.cpp @@ -9,16 +9,12 @@ #include #include -#include #include "fbpcs/data_processing/sharding/HashBasedSharder.h" #include "fbpcs/data_processing/sharding/RoundRobinBasedSharder.h" #include "fbpcf/engine/util/AesPrgFactory.h" -#include "fbpcf/engine/util/util.h" #include "fbpcf/mpc_std_lib/util/secureSamplePublicSeed.h" -#include "fbpcs/data_processing/common/FilepathHelpers.h" -#include "fbpcs/data_processing/common/Logging.h" #include "fbpcs/data_processing/sharding/SecureRandomSharder.h" namespace data_processing::sharder {