Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically fetch rules to generate sample->summary and target->summary #15

Open
sveinugu opened this issue Aug 8, 2020 · 0 comments
Open
Assignees

Comments

@sveinugu
Copy link
Contributor

sveinugu commented Aug 8, 2020

sample_type->summary is generated based on a hard-coded map from biospecimen_class to a particular sample_type sub-property. This map might change in future versions of the standard, and it is thus better to dynamically fetch this map from the standard, where it is encoded as value=>required rules within the allOf rules in the sample schema.

Similar value=>required rules are encoded within the allOf part of the experiment schema, this time mapping from technique value to corresponding target sub-properties. In the current code, all target subproperties are looped through, and the first value found is copied to the summary property, which is an error-prone solution.

Not required for FAIRtracks v2.0, but would be nice.

@sveinugu sveinugu changed the title Augment target_summary according to technique Dynamically fetch rules to generate sample->summary and target->summary Aug 8, 2020
@sveinugu sveinugu assigned sveinugu and unassigned radmilak Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants