Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Use farm_ng.core.Timestamp #87

Open
edgarriba opened this issue Mar 13, 2023 · 1 comment
Open

[Feature Request]: Use farm_ng.core.Timestamp #87

edgarriba opened this issue Mar 13, 2023 · 1 comment
Assignees

Comments

@edgarriba
Copy link
Member

edgarriba commented Mar 13, 2023

Describe the feature you want

currently, all the protos in this project define time stamps with as double, however, to be more consistent with the rest of the farm-ng ecosystem libraries we could use the farm_ng.core.Timestamp data structure

https://github.com/farm-ng/farm-ng-core/blob/main/protos/farm_ng/core/timestamp.proto#L21-L25

message Timestamp {
    double stamp = 1;
    string clock_name = 2;
    string semantics = 3;
}
@Hackerman342
Copy link
Collaborator

This should be done so it is non-breaking for anyone using the double stamp directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants