Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write monotonic stamp as the last element in the stamps list by convention #61

Open
ethanrublee opened this issue Jan 11, 2023 · 1 comment
Assignees

Comments

@ethanrublee
Copy link
Member

timestamps.append(get_system_clock_now(semantics="log/write"))

As a reader of logs, i'd like to depend on event.stamps[-1] always being the monotonic stamp, as this makes it easy/cheap to sort the events by write order without searching for the stamp by clock name.

@ethanrublee ethanrublee self-assigned this Jan 11, 2023
@edgarriba
Copy link
Member

even probably the semantic value should be different ? like

     timestamps.append(get_system_clock_now(semantics="log/clock/system"))
     timestamps.append(get_monotonic_now(semantics="log/clock/monotonic"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants