Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the notebook erases undo history #18

Open
Taytay opened this issue Apr 3, 2023 · 4 comments
Open

Cleaning the notebook erases undo history #18

Taytay opened this issue Apr 3, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Taytay
Copy link
Contributor

Taytay commented Apr 3, 2023

This makes sense, but code formatters don't seem to have this problem. Could this be done in a similar way somehow, so that I can keep the ability to undo?

@hamelsmu
Copy link
Member

hamelsmu commented Apr 3, 2023

I'm not sure tbh are you able to undo the similar action in a jupyter notebook after a clean operation?

@rebornix
Copy link

rebornix commented Apr 4, 2023

Once we finalize onWillSaveNotebookDocument in VS Code, maybe we could listen to this event and return edits for it so VS Code can handle the edit and also undo/redo for it automatically.

It seems right now nbdev is editing the ipynb file directly, is this correct @hamelsmu ?

@hamelsmu
Copy link
Member

hamelsmu commented Apr 4, 2023

That's correct I didn't realize there was a way to submit edits I'll look into that

@Taytay
Copy link
Contributor Author

Taytay commented Apr 4, 2023

I'm not sure tbh are you able to undo the similar action in a jupyter notebook after a clean operation?

I'm too new to the world of Notebooks to know! This is my first time cleaning them :)

@seeM seeM added the bug Something isn't working label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants