Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments must be stripped before calling shlex.split #232

Open
rgov opened this issue May 25, 2021 · 0 comments
Open

Comments must be stripped before calling shlex.split #232

rgov opened this issue May 25, 2021 · 0 comments
Assignees
@fboender
Labels
bug hasfix

Comments

@rgov
Copy link

rgov commented May 25, 2021 •
edited
Loading

shlex.split does not understand shell comments. Because of this, a line containing a perfectly valid comment could cause a parse error: shlex.split("# Don't panic") triggers a "No closing quotation" error because of the apostrophe in the comment.

See #214 for a new parser implementation with tests that appears to avoid the issue.
@fboender fboender self-assigned this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fboender fboender

Labels
bug hasfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgov @fboender