Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error thrown when files analized by Steiger contain invalid syntax #60

Open
daniilsapa opened this issue Jul 18, 2024 · 4 comments
Labels
PRIORITY | LOW Can wait until after release TYPE | bug Something isn't working

Comments

@daniilsapa
Copy link
Collaborator

It throws the error when you specify a path in the following format e.g. ../source, ../../src etc., when you exit the working folder in your path.

349515804-e0902c0c-1105-467c-9d49-0aa946e9de9c
@daniilsapa
Copy link
Collaborator Author

Weird, but today I could reproduce this error with a folder that's inside the working folder.

Screenshot 2024-07-18 at 14 20 28 Screenshot 2024-07-18 at 14 22 16

@daniilsapa
Copy link
Collaborator Author

daniilsapa commented Jul 18, 2024

Sorry, this error occurred because I wrote tests for my application and then got distracted and left an invalid syntax construction in the code 🤦‍♂️

Screenshot 2024-07-18 at 14 30 46

But still, shouldn't it handle such a case (when one or more files cannot be correctly parsed because of invalid syntax) more gracefully? Rather than just give us that vague error message?

@daniilsapa daniilsapa changed the title Fix the error thrown when you provide Steiger with a path that's outside the working folder Fix the error thrown when files analized by Steiger contain invalid syntax Jul 18, 2024
@daniilsapa
Copy link
Collaborator Author

Updated the title to reflect the newly identified cause of the error

@illright
Copy link
Member

Yeah, we should definitely handle parsing errors more gracefully

@illright illright added TYPE | bug Something isn't working PRIORITY | LOW Can wait until after release labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY | LOW Can wait until after release TYPE | bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants