Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steiger looses the context of its config when called from a subfolder #62

Open
daniilsapa opened this issue Jul 18, 2024 · 1 comment
Open
Labels
PRIORITY | LOW Can wait until after release TYPE | bug Something isn't working
Milestone

Comments

@daniilsapa
Copy link
Collaborator

I have a steiger.config.ts in the root of my project. I temporarily disabled a rule in my steiger.config.ts. When I run steiger ./src from the project root it ignores errors related to that rule. But when I enter a subfolder and then run steiger ../src it starts to report errors related to that disabled rule.

Seems like it only parses the working directory when searching for the config. Shouldn't it recursively go up through the folders to find a config?

@illright
Copy link
Member

Interesting, I thought it already worked like that. However, I'm not sure how beneficial this feature is. We might consider that if you don't have the config in the current directory, you should specify the path explicitly. Idk. Or maybe we can just implement this behavior and not think too hard

@illright illright added TYPE | bug Something isn't working PRIORITY | LOW Can wait until after release labels Jul 19, 2024
@illright illright added this to the 0.6.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY | LOW Can wait until after release TYPE | bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants