Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement no-circular-imports #87

Open
Tracked by #2
illright opened this issue Aug 19, 2024 · 1 comment
Open
Tracked by #2

Implement no-circular-imports #87

illright opened this issue Aug 19, 2024 · 1 comment
Labels
PRIORITY | HIGH Important and significant
Milestone

Comments

@illright
Copy link
Member

illright commented Aug 19, 2024

This should probably be implemented outside of the FSD plugin, since it's not exclusive to FSD. I'm not sure if it's best to create another native plugin or have this rule in "Steiger core"

The idea of this rule is simple — prevent circular imports (when A imports from B, but B imports from A, or maybe A -> B -> C -> ... -> A).


For simplicity, let's put this rule to the FSD plugin for now, and if there will be more generic rules like this, then we'll think about moving them out into a separate plugin

@illright illright mentioned this issue Aug 19, 2024
16 tasks
@illright illright added the PRIORITY | LOW Can wait until after release label Aug 19, 2024
@illright
Copy link
Member Author

We might be able to learn from this project — https://github.com/antoine-coulon/skott

@illright illright added PRIORITY | HIGH Important and significant and removed PRIORITY | LOW Can wait until after release labels Dec 4, 2024
@illright illright added this to the 0.6.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY | HIGH Important and significant
Projects
None yet
Development

No branches or pull requests

1 participant