Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate preview links for review before merging #2325

Open
BigLep opened this issue Sep 25, 2024 · 3 comments
Open

Generate preview links for review before merging #2325

BigLep opened this issue Sep 25, 2024 · 3 comments

Comments

@BigLep
Copy link
Member

BigLep commented Sep 25, 2024

I'm hoping there is a way to get preview links of what the rendered PR looks like before merging.

For example, Lotus docs has:
image
which allow checking of the rendered output.

Does Filecoin docs have anything similar?

And maybe related, should we document how the site is published/served? (I'm thinking something like https://github.com/filecoin-project/lotus-docs?tab=readme-ov-file#publishing )

@BigLep
Copy link
Member Author

BigLep commented Sep 25, 2024

@lanzafame : do you know if there are preview links?

@BigLep
Copy link
Member Author

BigLep commented Oct 7, 2024

@lanzafame : I'm not sure if you did this, but it looks resolved now.

From #2327
image

I'm not sure how this is configured (I don't see a .yml file). Maybe document the integration and then this gets closed?

@lanzafame
Copy link
Collaborator

@BigLep firstly sorry the slow reply. I did not do anything to enable the preview to show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@BigLep @lanzafame and others