From 0693dd25a6c83f55c6e3844343366c2f0ffa0199 Mon Sep 17 00:00:00 2001 From: rosariopf Date: Wed, 28 Aug 2024 16:26:52 +0100 Subject: [PATCH] target api level 34 and re-enable hints --- .../com/firebase/ui/auth/ui/email/CheckEmailFragment.java | 8 ++++---- .../ui/auth/ui/phone/CheckPhoneNumberFragment.java | 8 ++++---- buildSrc/src/main/kotlin/Config.kt | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java index deaa747da..5156d82a2 100644 --- a/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java +++ b/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java @@ -90,10 +90,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat ImeHelper.setImeOnDoneListener(mEmailEditText, this); - // TODO(hackathon): figure out if we want to have autofill or not. -// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { -// mEmailEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); -// } + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE && + getFlowParams().enableCredentialsManager) { + mEmailEditText.setIsCredential(true); + } mNextButton.setOnClickListener(this); diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java b/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java index 230fef1dc..e7e928675 100644 --- a/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java +++ b/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java @@ -89,10 +89,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat mSmsTermsText.setText(getString(R.string.fui_sms_terms_of_service, getString(R.string.fui_verify_phone_number))); - // TODO(hackathon): figure out if we want to have autofill or not. -// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { -// mPhoneEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); -// } + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE && + getFlowParams().enableCredentialsManager) { + mPhoneEditText.setIsCredential(true); + } requireActivity().setTitle(getString(R.string.fui_verify_phone_number_title)); ImeHelper.setImeOnDoneListener(mPhoneEditText, () -> onNext()); diff --git a/buildSrc/src/main/kotlin/Config.kt b/buildSrc/src/main/kotlin/Config.kt index f93168251..f7b0cc17e 100644 --- a/buildSrc/src/main/kotlin/Config.kt +++ b/buildSrc/src/main/kotlin/Config.kt @@ -5,8 +5,8 @@ object Config { private const val kotlinVersion = "1.8.21" object SdkVersions { - const val compile = 33 - const val target = 33 + const val compile = 34 + const val target = 34 const val min = 21 }