Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config URL param for threshold #198

Open
jchris opened this issue Sep 2, 2024 · 3 comments
Open

config URL param for threshold #198

jchris opened this issue Sep 2, 2024 · 3 comments

Comments

@jchris
Copy link
Contributor

jchris commented Sep 2, 2024

this should look like the fragmentation config

@jchris
Copy link
Contributor Author

jchris commented Sep 3, 2024

#185

@valorant-dhruv
Copy link
Contributor

valorant-dhruv commented Sep 5, 2024

Here's what I am thinking. Because the threshold is either what end user passes ( who isn't aware of limitations of some connectors) or a hardcoded value, it's better to add a connector parameter inside the super this class and create a new threshold function which either returns a default value or threshold value specific to the connnector. We will keep updating this parameter for a particular database depending on which remote is being used.

@valorant-dhruv
Copy link
Contributor

Because this is inside core fireproof, I am not using gateway functions and URLs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants