Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode relay addresses in the builder #305

Open
ferranbt opened this issue Dec 19, 2024 · 3 comments · May be fixed by #321
Open

Hardcode relay addresses in the builder #305

ferranbt opened this issue Dec 19, 2024 · 3 comments · May be fixed by #321
Labels
good first issue Good for newcomers

Comments

@ferranbt
Copy link
Contributor

Right now, the user has to supply a list of configuration for all the builders he wants to connect to:

[[relays]]
name = "flashbots"
url = "https://0xac6e77dfe25ecd6110b8e780608cce0dab71fdd5ebea22a16c0205200f2f8e2e3ad3b71d3499c54ad14d6c21b41a37ae@boost-relay.flashbots.net"
priority = 0
use_ssz_for_submit = false
use_gzip_for_submit = false

Instead, we should built-in these configurations inside the rbuilder and let the user choose which one wants to use.

@ferranbt ferranbt added the C-discussion Issues that require team discussion or decision-making before proceeding. label Dec 19, 2024
@bertmiller
Copy link
Member

No strong feelings here. Maybe the compromise path could be allowing for custom relays in addition to the presets.

@ferranbt
Copy link
Contributor Author

Yes, so now you have to do:

[[relays]]
name = "flashbots"
url = "https://0xac6e77dfe25ecd6110b8e780608cce0dab71fdd5ebea22a16c0205200f2f8e2e3ad3b71d3499c54ad14d6c21b41a37ae@boost-relay.flashbots.net"
priority = 0
use_ssz_for_submit = false
use_gzip_for_submit = false

[[relays]]
name = "relay-2"
url = "..."
priority = 0
use_ssz_for_submit = false
use_gzip_for_submit = false

[[relays]]
name = "relay-3"
url = "..."
priority = 0
use_ssz_for_submit = false
use_gzip_for_submit = false

With the new change you would something like this:

relays = ["flashbots", "relay-3"]

[[relays]]
name = "flashbots"
use_gzip_for_submit = true

[[relays]]
name = "relay-3"
url = "..."
priority = 0
use_ssz_for_submit = false
use_gzip_for_submit = false

You could even override some of the default presents.

@bertmiller
Copy link
Member

Exactly

@ferranbt ferranbt added good first issue Good for newcomers and removed C-discussion Issues that require team discussion or decision-making before proceeding. labels Dec 19, 2024
@ferranbt ferranbt linked a pull request Dec 31, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants