Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email 2FA verfication - FE followup #24380

Closed
3 tasks done
RachelElysia opened this issue Dec 4, 2024 · 5 comments
Closed
3 tasks done

Email 2FA verfication - FE followup #24380

RachelElysia opened this issue Dec 4, 2024 · 5 comments
Assignees
Labels
~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone

Comments

@RachelElysia
Copy link
Member

RachelElysia commented Dec 4, 2024

Follow up to track final updates needed for #22789

  • integrate with API
  • wire the /login/expired and login/2fa pages correctly
  • add email address from api to the login/2fa page
    - [ ] hear back from product/design on radio button help text (github comment) @rachaelshaw said this might take a bit to determine (1:30 est 12/5/24)
    - [ ] remove commented out help text on radio button if needed ^ see above
    - [ ] hear back from product/design about scrollable modal design decision (slack) @marko-lisica added it to weekly design sync agenda
    - [ ] update validation pattern if capacity allows
@RachelElysia RachelElysia added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels Dec 4, 2024
@RachelElysia RachelElysia self-assigned this Dec 4, 2024
@RachelElysia RachelElysia added ~frontend Frontend-related issue. P2 Prioritize as urgent labels Dec 4, 2024
@sharon-fdm sharon-fdm modified the milestones: 4.61.0, Fleetd-1.37.0 Dec 10, 2024
@lucasmrod
Copy link
Member

@sharon-fdm This change doesn't look fleetd related, should this have the 4.61.0 milestone?

@jmwatts
Copy link
Member

jmwatts commented Dec 11, 2024

@RachelElysia is this a subtask of #22078? Is there anything specific that should be tested for this ticket that wasn't covered in #22078?

@lukeheath lukeheath modified the milestones: Fleetd-1.37.0, 4.61.0 Dec 11, 2024
@lukeheath
Copy link
Member

@sharon-fdm Wrong milestone on this one, I corrected.

@sharon-fdm
Copy link
Collaborator

Thanks @lucasmrod and @lukeheath. I set the milestone by mistake.

@fleet-release
Copy link
Contributor

Two-factor secure,
Like a cloud city's locked door,
Peace for data pure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group P2 Prioritize as urgent :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Development

No branches or pull requests

6 participants