Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --> (arrows) from the "Solutions" in the MDM table on the bottom of the Dashboard page. #24962

Open
eugkuo opened this issue Dec 20, 2024 · 2 comments
Open

Remove --> (arrows) from the "Solutions" in the MDM table on the bottom of the Dashboard page. #24962

eugkuo opened this issue Dec 20, 2024 · 2 comments
Assignees
@eugkuo
Labels
bug Something isn't working as documented #g-software Software product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board)

Comments

@eugkuo
Copy link
Contributor

eugkuo commented Dec 20, 2024

Fleet version: Fleet 4.61.0 • Go go1.23.4

Web browser and operating system: Safari Version 18.2 (20620.1.16.11.8) on MacOS

💥  Actual behavior

Screenshot 2024-12-20 at 21 18 07
Currently there are arrows next to the solutions (Fleet, Jamf) in the Solutions table. Elsewhere on the page it's established that the arrows indicate that clicking on the link will take the user to a new page. These links open up modals so the arrows are incongruous with expected behavior.

🧑‍💻  Steps to reproduce

  1. Navigate to https://dogfood.fleetdm.com/dashboard
  2. Scroll to bottom of page.
@eugkuo eugkuo added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Dec 20, 2024
@jmwatts
Copy link
Member

jmwatts commented Dec 23, 2024

Reproduced in Dogfood and local instance. Confirmed other clickable objects in the UI with an "arrow" (such as "View all hosts -->" or "View all software -->" take you to a new page, while these particular links just open a modal.

@jmwatts jmwatts added :product Product Design department (shows up on 🦢 Drafting board) and removed :reproduce Involves documenting reproduction steps in the issue labels Dec 23, 2024
@noahtalerman noahtalerman added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-software Software product group and removed :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels Dec 24, 2024
@noahtalerman
Copy link
Member

Hey @eugkuo thanks for tracking this! I assigned this bug to you.

Can you please add a screenshot or Figma file (something that shows the expected behavior) to the "To fix" section so that the developer and QA engineer working on this quickly knows what the definition of done/fixed is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugkuo eugkuo

Labels
bug Something isn't working as documented #g-software Software product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eugkuo @noahtalerman @jmwatts