Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software_title_id not displayed in Activities when Editing Software Installers #24970

Open
PezHub opened this issue Dec 20, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.

Comments

@PezHub
Copy link
Contributor

PezHub commented Dec 20, 2024

Fleet version: Main branch

Web browser and operating system:


💥  Actual behavior

When editing existing software in the Fleet UI, we see software_title_id for the added_software activity but NOT edited_software

🧑‍💻  Steps to reproduce

  1. Edit existing pkg on a team in the Fleet UI
  2. Inspect the API Response
  3. Note the lack of software_title_id for edited_software

🕯️ More info (optional)

should have been added as part of #24120

Screenshot 2024-12-20 at 12 49 48 PM

"activities": [
    {
      "created_at": "2024-12-20T20:45:49.416877Z",
      "id": 1134,
      "actor_full_name": "API User",
      "actor_id": 2,
      "actor_gravatar": "",
      "actor_email": "[email protected]",
      "type": "edited_software",
      "details": {
        "team_id": 33,
        "team_name": "New_One",
        "self_service": false,
        "software_title": "com.github.munki.pkg.fleet-logo",
        "software_package": "dummy-bootstrap-package.pkg"
      }
    },
    {
      "created_at": "2024-12-20T20:42:46.005866Z",
      "id": 1133,
      "actor_full_name": "API User",
      "actor_id": 2,
      "actor_gravatar": "",
      "actor_email": "[email protected]",
      "type": "deleted_software",
      "details": {
        "team_id": 0,
        "team_name": null,
        "self_service": false,
        "software_title": "com.github.munki.pkg.fleet-logo",
        "software_package": "dummy-bootstrap-package.pkg"
      }
    },
    {
      "created_at": "2024-12-20T20:42:45.908757Z",
      "id": 1132,
      "actor_full_name": "API User",
      "actor_id": 2,
      "actor_gravatar": "",
      "actor_email": "[email protected]",
      "type": "added_software",
      "details": {
        "team_id": 33,
        "team_name": "New_One",
        "self_service": false,
        "software_title": "com.github.munki.pkg.fleet-logo",
        "software_package": "dummy-bootstrap-package.pkg",
        "software_title_id": 4072
      }
    },

Questions for Product:

  1. Should deleted_software type also expose the software_title_id
  2. Should VPP apps be in scope? currently they are not.
  3. Should changes via CLI be in scope? currently they are not
    @noahtalerman @marko
@PezHub PezHub added bug Something isn't working as documented :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-mdm MDM product group ~unreleased bug This bug was found in an unreleased version of Fleet. :incoming New issue in triage process. labels Dec 20, 2024
@jahzielv jahzielv self-assigned this Dec 20, 2024
@jahzielv jahzielv mentioned this issue Dec 20, 2024
2 tasks
jahzielv added a commit that referenced this issue Dec 24, 2024
> Related issue: #24970

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Development

No branches or pull requests

2 participants