Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move certain files to a plugin directory #6

Open
1 of 3 tasks
ibrahim-mubarak opened this issue Apr 14, 2019 · 2 comments
Open
1 of 3 tasks

Move certain files to a plugin directory #6

ibrahim-mubarak opened this issue Apr 14, 2019 · 2 comments

Comments

@ibrahim-mubarak
Copy link
Contributor

ibrahim-mubarak commented Apr 14, 2019 •
edited
Loading

Following files should not be part of the framework and should be moved to plugins

  • ApiClient
  • Error Reporters
  • Json Localizer
@shbmbhrdwj shbmbhrdwj changed the title Move API Client to a plugin Move certain files to a plugin directory Apr 14, 2019
@ibrahim-mubarak
Copy link
Contributor Author

API client should not be part of the framework, It should be provided by the user.
If the framework needs to use an API, it should expose an Interface for the same.

@ibrahim-mubarak
Copy link
Contributor Author

These Plugins should be moved to another plugin repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibrahim-mubarak