Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Jar Name #56

Open
Olthoo opened this issue Jun 30, 2024 · 4 comments
Open

Custom Jar Name #56

Olthoo opened this issue Jun 30, 2024 · 4 comments

Comments

@Olthoo
Copy link

Olthoo commented Jun 30, 2024

It would be interesting to allow users to change the naming of the jars with placeholders

The line is the config.yml could look like that

jar-format: "[PP] {plugin-name} {Source} {version}"

My Discord if you need more infos : Olthoo

@Dawsson
Copy link
Member

Dawsson commented Jul 1, 2024

Could cause issues with the auto updating, commenting to remind us later on

@Olthoo
Copy link
Author

Olthoo commented Jul 1, 2024

Maybe make the plugin-name mandatory to avoid confusion ?

@Dawsson
Copy link
Member

Dawsson commented Jul 1, 2024

What worries me is them changing it after already installing some plugins. Possibly we could rename all the files?

@Dawsson
Copy link
Member

Dawsson commented Jul 1, 2024

We could allow this on paper. Just got told from a Spigot staff member that it uses the file name where as on paper it uses the plugin.yml name.

There is a PR for it to use the plugin.yml name on spigot but unmerged.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants