Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Turn on strictMode for propeller and propeller-manager config load #3113

Open
2 tasks done
pmahindrakar-oss opened this issue Nov 29, 2022 · 3 comments · May be fixed by flyteorg/flytepropeller#505
Open
2 tasks done

[BUG] Turn on strictMode for propeller and propeller-manager config load #3113

pmahindrakar-oss opened this issue Nov 29, 2022 · 3 comments · May be fixed by flyteorg/flytepropeller#505
Assignees
@pmahindrakar-oss
Labels
bug Something isn't working
Milestone
2023 Backlog

Comments

@pmahindrakar-oss
Copy link
Contributor

Describe the bug

Currently though the configAccessor is defined to load the config in strictMode which makes sure incorrect config keys cause a fast failure , but it turned off during app initialization here

Similar behavior has been replicated in propeller manager too

Expected behavior

StrictMode should be turned on to catch incorrect config errors faster

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Nov 29, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.3.0 milestone Nov 29, 2022
@pmahindrakar-oss pmahindrakar-oss removed the untriaged This issues has not yet been looked at by the Maintainers label Nov 29, 2022
@pmahindrakar-oss pmahindrakar-oss linked a pull request Nov 29, 2022 that will close this issue
Open
8 tasks
@pingsutw
Copy link
Member

pingsutw commented Jan 9, 2023

flyteorg/flytepropeller#505

@cosmicBboy cosmicBboy modified the milestones: 1.3.0, 2023 Q1 Backlog Jan 25, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 23, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmahindrakar-oss pmahindrakar-oss

Labels
bug Something isn't working
Projects
None yet
Milestone
2023 Backlog
Development

Successfully merging a pull request may close this issue.

Turning on strictMode for propeller and manager config flyteorg/flytepropeller
4 participants
@eapolinario @cosmicBboy @pingsutw @pmahindrakar-oss