-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite as a pure-python wrapper of kyamagu/skia-python? #38
Comments
Or maybe I just build the linux and macos skia static libraries once and for all, like we already do for windows in https://github.com/fonttools/skia-builder, and download the pre-compiled object that can I link in the cython extension module.. |
Your first idea was better. This one would make for a downstream nightmare when packaging for distros (I say this as one of the the Arch Linux maintainers for both this an |
downloading the pre-compiled blobs is only meant for the CI setup that builds the python wheels. skia-pathops extension module can be built from source without problems (bulinding from source is the default setting), whether with an embedded skia static library or by pointing to an external skia library (the latter is likely the preferred approach for distro maintainers). |
Oh, my bad. I misunderstood what you were talking about there. As long as building from source is the default (or a possible) build configuration for distro packaging purposes I guess it doesn't matter to me much how PyPi comes by its wheels. |
Building skia is slow, we have to do it each time we push. There's a new project that provides cross-platform python bindings to the Skia library and publishes wheels for the three platforms we support:
https://github.com/kyamagu/skia-python
I'm thinking that we could rewrite skia-pathops such that it imports from this skia-python bindings, while maintaining our current fontmake-friendly interface.
The text was updated successfully, but these errors were encountered: