Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate article unit convertion from ST to KI (german foodcoops legacy) #1059

Open
yksflip opened this issue Mar 29, 2024 · 0 comments
Open
Milestone

Comments

@yksflip
Copy link
Member

yksflip commented Mar 29, 2024

in models/article.rb is this convert_units special case that converts articles with the unit 'KI' (Kiste) to 'ST' (Stück). The comment says, that it's some legacy feature for german foodcoops. With the upcoming article_versions, this get's super obsolete. Will anyone still relies on that or can we deprecate it after we merged article_versions?

https://github.com/foodcoops/foodsoft/blob/master/app/models/article.rb#L195
https://github.com/foodcoopsat/foodsoft_hackathon/blob/master/app/models/article.rb#L201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant