Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots of Website or only open meta tag image #87

Open
nocomment-bln opened this issue Jun 4, 2023 · 6 comments
Open

Screenshots of Website or only open meta tag image #87

nocomment-bln opened this issue Jun 4, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@nocomment-bln
Copy link

Hello,
does benotes only use the image of open graph meta ?

a screenshot function would be very nice! :)

@nocomment-bln
Copy link
Author

BTW: an option to move or delete multiple items would be nice :)

really good projekt which you've build there! like it

@fr0tt
Copy link
Owner

fr0tt commented Jun 4, 2023

Hi,

thank you and you're right that wouldn't be a bad idea ;)

if it can't find an (open graph meta) image it actually takes a screenshot.

You can also trigger this manually with this command (and a post id):

php artisan thumbnail:generate

@nocomment-bln
Copy link
Author

nocomment-bln commented Jun 4, 2023

thank you and you're right that wouldn't be a bad idea ;)

Yes move,delete and all the stuff for multiple items :)

--And maybe some kind of setting where you can choose if you would like to have to open meta image or screenshot.. a screenshot even open meta image is available
-- It would be also nice to have the option to sort the items in a collection. Filter or custom order or something like that.
-- also nice would be if the subfolder would be seen all the time.
maybe some nice features for the future!

Taking screenshots are not really working :/
CleanShot 2023-06-04 at 17 01 07@2x

@fr0tt fr0tt added the bug Something isn't working label Jun 7, 2023
@fr0tt fr0tt added this to Benotes Jun 7, 2023
@fr0tt fr0tt moved this to 🏗 In progress in Benotes Jun 7, 2023
@fr0tt
Copy link
Owner

fr0tt commented Jul 28, 2023

Screenshots should be working now with v2.7.1

@fr0tt fr0tt removed the bug Something isn't working label Aug 13, 2023
@nocomment-bln
Copy link
Author

Thanks :)

what about the feature request ? :D :D

@fr0tt
Copy link
Owner

fr0tt commented Aug 23, 2023

I like to think of them as feature requestS ;)
I haven't forgotten them, but the first and second require a redesign of their respected area and the last one could be cool, but maybe not necessarily for everyone, because some might be happy that their open/closed collection amagedon is automatically cleaned up for them.

@fr0tt fr0tt added the enhancement New feature or request label Aug 23, 2023
@fr0tt fr0tt removed this from Benotes Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants