From f8512cb4a0b2f0ce0de91397ec3e4a3811acf400 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 24 Oct 2024 14:17:40 +0530
Subject: [PATCH 1/6] fix: custom fields in filters in customer portal

---
 helpdesk/api/doc.py | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/helpdesk/api/doc.py b/helpdesk/api/doc.py
index 9369dd91c..06007ee28 100644
--- a/helpdesk/api/doc.py
+++ b/helpdesk/api/doc.py
@@ -68,23 +68,28 @@ def get_filterable_fields(doctype: str, show_customer_portal_fields=False):
     )
 
     # for customer portal show only fields present in customer_portal_fields
-
     if show_customer_portal_fields:
         from_doc_fields = from_doc_fields.where(
             QBDocField.fieldname.isin(customer_portal_fields)
         )
-        from_custom_fields = from_custom_fields.where(
-            QBCustomField.fieldname.isin(visible_custom_fields)
-        )
+        if len(visible_custom_fields) > 0:
+            from_custom_fields = from_custom_fields.where(
+                QBCustomField.fieldname.isin(visible_custom_fields)
+            )
+            from_custom_fields = from_custom_fields.run(as_dict=True)
+        else:
+            from_custom_fields = []
 
-    from_doc_fields = from_doc_fields.run(as_dict=True)
-    from_custom_fields = from_custom_fields.run(as_dict=True)
+    if not show_customer_portal_fields:
+        from_custom_fields = from_custom_fields.run(as_dict=True)
 
+    from_doc_fields = from_doc_fields.run(as_dict=True)
     # from hd ticket template get children with fieldname and hidden_from_customer
 
     res = []
     res.extend(from_doc_fields)
     # TODO: Ritvik => till a better way we have for custom fields, just show custom fields
+
     res.extend(from_custom_fields)
     if not show_customer_portal_fields:
         res.append(

From 097bdf62ce93f27a1615808bf6e8eec0669653f0 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 24 Oct 2024 14:35:27 +0530
Subject: [PATCH 2/6] fix(styles): article page

---
 desk/src/pages/KnowledgeBaseArticle.vue | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/desk/src/pages/KnowledgeBaseArticle.vue b/desk/src/pages/KnowledgeBaseArticle.vue
index 6581796d7..1af81d31b 100644
--- a/desk/src/pages/KnowledgeBaseArticle.vue
+++ b/desk/src/pages/KnowledgeBaseArticle.vue
@@ -1,10 +1,10 @@
 <template>
   <div class="flex h-full flex-col overflow-hidden">
-    <PageTitle>
-      <template #title>
+    <LayoutHeader>
+      <template #left-header>
         <Breadcrumbs :items="breadcrumbs" />
       </template>
-      <template #right v-if="!route.meta.public">
+      <template #right-header v-if="!isCustomerPortal">
         <component
           :is="actionsComponent"
           :status="article.data?.status"
@@ -17,8 +17,8 @@
           @toggle-status="toggleStatus"
         />
       </template>
-    </PageTitle>
-    <div class="overflow-auto">
+    </LayoutHeader>
+    <div class="overflow-auto mx-auto w-full max-w-4xl px-5">
       <div class="mx-5 my-12">
         <TextEditor
           :content="textEditorContentWithIDs"
@@ -56,12 +56,14 @@
         <RouterLink
           v-if="route.meta.public"
           :to="{ name: CUSTOMER_PORTAL_NEW_TICKET }"
+          class=""
         >
           <Button
             label="Still need help? Create a ticket"
             size="md"
             theme="gray"
             variant="solid"
+            class="mt-5"
           >
             <template #suffix> &rightarrow; </template>
           </Button>
@@ -93,7 +95,7 @@ import { createToast } from "@/utils";
 import { useAuthStore } from "@/stores/auth";
 import { useError } from "@/composables/error";
 
-import { PageTitle } from "@/components";
+import { LayoutHeader, PageTitle } from "@/components";
 import KnowledgeBaseArticleActionsEdit from "./knowledge-base/KnowledgeBaseArticleActionsEdit.vue";
 import KnowledgeBaseArticleActionsNew from "./knowledge-base/KnowledgeBaseArticleActionsNew.vue";
 import KnowledgeBaseArticleActionsView from "./knowledge-base/KnowledgeBaseArticleActionsView.vue";

From 00c03213c8075a830f70fb715d0c5b9aa917ff77 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 24 Oct 2024 16:44:32 +0530
Subject: [PATCH 3/6] fix(styles): customer portal

---
 desk/src/pages/KnowledgeBaseArticle.vue | 2 +-
 desk/src/pages/TicketNew.vue            | 2 +-
 frappe-ui                               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/desk/src/pages/KnowledgeBaseArticle.vue b/desk/src/pages/KnowledgeBaseArticle.vue
index 1af81d31b..06e6326a2 100644
--- a/desk/src/pages/KnowledgeBaseArticle.vue
+++ b/desk/src/pages/KnowledgeBaseArticle.vue
@@ -19,7 +19,7 @@
       </template>
     </LayoutHeader>
     <div class="overflow-auto mx-auto w-full max-w-4xl px-5">
-      <div class="mx-5 my-12">
+      <div class="py-6">
         <TextEditor
           :content="textEditorContentWithIDs"
           :editable="editMode"
diff --git a/desk/src/pages/TicketNew.vue b/desk/src/pages/TicketNew.vue
index 41c463be5..a8c11d8f5 100644
--- a/desk/src/pages/TicketNew.vue
+++ b/desk/src/pages/TicketNew.vue
@@ -7,7 +7,7 @@
     </LayoutHeader>
     <!-- Container -->
     <div
-      class="max-w-screen-lg flex flex-col gap-5 m-5 w-full h-full flex-1 self-center"
+      class="flex flex-col gap-5 py-6 h-full flex-1 self-center overflow-auto mx-auto w-full max-w-4xl px-5"
     >
       <!-- custom fields descriptions -->
       <div v-if="Boolean(template.data?.about)" class="">
diff --git a/frappe-ui b/frappe-ui
index 9f927012a..3b413c7ed 160000
--- a/frappe-ui
+++ b/frappe-ui
@@ -1 +1 @@
-Subproject commit 9f927012a3ef54e934fa01bea07b57f8ec06617c
+Subproject commit 3b413c7ed6509bdeb0599728ee2cccd0ab040ac9

From 2f9a0c20c22d8f5b7bcdc775594854e37c4f3413 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 24 Oct 2024 18:57:56 +0530
Subject: [PATCH 4/6] fix: _assign issue

---
 helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py b/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
index c915cc34f..da3acb747 100644
--- a/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
+++ b/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
@@ -213,14 +213,14 @@ def on_update(self):
         self.publish_update()
         self.update_search_index()
 
-    def notify_agent(self, agent, notiification_type="Assignment"):
+    def notify_agent(self, agent, notification_type="Assignment"):
         frappe.get_doc(
             frappe._dict(
                 doctype="HD Notification",
                 user_from=frappe.session.user,
                 reference_ticket=self.name,
                 user_to=agent,
-                notification_type=notiification_type,
+                notification_type=notification_type,
             )
         ).insert(ignore_permissions=True)
 
@@ -343,7 +343,7 @@ def remove_assignment_if_not_in_team(self):
         """
         if self.is_new():
             return
-        if not self.agent_group or not self._assign:
+        if not self.agent_group or (hasattr(self, "_assign") and not self._assign):
             return
         if self.has_value_changed("agent_group") and self.status == "Open":
             current_assigned_agent_doc = self.get_assigned_agent()

From 41b9f2de1ac947c0a1c33fc2ab0dba05c93e92f4 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Fri, 25 Oct 2024 12:12:39 +0530
Subject: [PATCH 5/6] fix(styes): email and comment activity

---
 desk/src/components/CommentBox.vue            | 56 +++++++++++--------
 desk/src/components/EmailArea.vue             | 32 +++++------
 .../ticket/TicketAgentActivities.vue          | 46 ++++++++-------
 .../components/ticket/TicketAgentContact.vue  |  2 +-
 4 files changed, 77 insertions(+), 59 deletions(-)

diff --git a/desk/src/components/CommentBox.vue b/desk/src/components/CommentBox.vue
index ab4e4c556..60f978a8b 100644
--- a/desk/src/components/CommentBox.vue
+++ b/desk/src/components/CommentBox.vue
@@ -1,31 +1,39 @@
 <template>
   <div class="flex-col text-base">
-    <div class="mb-0.5 flex items-center justify-between">
-      <div class="text-gray-600">
-        <span class="font-medium text-gray-800">
-          {{ commenter }}
-        </span>
-        <span> added a</span>
-        <span class="max-w-xs truncate font-medium text-gray-800">
-          comment
-        </span>
-        <span class="px-1">&middot;</span>
+    <div class="mb-1 ml-0.5 flex items-center justify-between">
+      <div class="text-gray-600 flex items-center gap-1">
+        <Avatar
+          size="sm"
+          :label="commenter"
+          :image="getUser(commentedBy).user_image"
+        />
+        <p>
+          <span class="font-medium text-gray-800">
+            {{ commenter }}
+          </span>
+          <span> added a</span>
+          <span class="max-w-xs truncate font-medium text-gray-800">
+            comment
+          </span>
+        </p>
+      </div>
+      <div class="flex gap-1 items-center">
         <Tooltip :text="dateFormat(creation, dateTooltipFormat)">
-          <span class="pl-0.5 text-sm">
+          <span class="pl-0.5 text-sm text-gray-600">
             {{ timeAgo(creation) }}
           </span>
         </Tooltip>
-      </div>
-      <div v-if="authStore.userId === commentedBy" class="px-4">
-        <Dropdown
-          :options="[{ label: 'Delete', onClick: () => (showDialog = true) }]"
-        >
-          <Button
-            icon="more-horizontal"
-            class="text-gray-600"
-            variant="ghost"
-          />
-        </Dropdown>
+        <div v-if="authStore.userId === commentedBy">
+          <Dropdown
+            :options="[{ label: 'Delete', onClick: () => (showDialog = true) }]"
+          >
+            <Button
+              icon="more-horizontal"
+              class="text-gray-600"
+              variant="ghost"
+            />
+          </Dropdown>
+        </div>
       </div>
     </div>
     <div
@@ -52,9 +60,10 @@
 
 <script setup lang="ts">
 import { ref } from "vue";
-import { Dropdown, createResource, Dialog } from "frappe-ui";
+import { Dropdown, createResource, Dialog, Avatar } from "frappe-ui";
 import { dateFormat, timeAgo, dateTooltipFormat, createToast } from "@/utils";
 import { useAuthStore } from "@/stores/auth";
+import { useUserStore } from "@/stores/user";
 
 const authStore = useAuthStore();
 const props = defineProps({
@@ -63,6 +72,7 @@ const props = defineProps({
     required: true,
   },
 });
+const { getUser } = useUserStore();
 
 const { name, creation, content, commenter, commentedBy } = props.activity;
 
diff --git a/desk/src/components/EmailArea.vue b/desk/src/components/EmailArea.vue
index e55cc7d73..b85ef17fc 100644
--- a/desk/src/components/EmailArea.vue
+++ b/desk/src/components/EmailArea.vue
@@ -1,33 +1,33 @@
 <template>
   <div
-    class="grow cursor-pointer rounded-md border-transparent bg-gray-50 text-base leading-6 transition-all duration-300 ease-in-out"
+    class="grow cursor-pointer border-transparent bg-white rounded-md shadow text-base leading-6 transition-all duration-300 ease-in-out"
   >
     <div class="mb-1 flex items-center justify-between gap-2">
-      <!-- comment design for mobile -->
+      <!-- email design for mobile -->
       <div v-if="isMobileView" class="flex items-center gap-2">
-        <UserAvatar :name="sender.name" size="lg" />
         <div class="leading-tight">
-          <span>{{ sender.full_name }}</span>
-          <Tooltip :text="dateFormat(creation, dateTooltipFormat)">
-            <div class="text-xs text-gray-600">
-              {{ timeAgo(creation) }}
-            </div>
-          </Tooltip>
+          <span>{{ sender.full_name || "No name found" }}</span>
+          <span
+            class="sm:flex hidden text-sm text-gray-600"
+            v-if="sender.name"
+            >{{ "<" + sender.name + ">" }}</span
+          >
         </div>
       </div>
-      <!-- comment design for desktop -->
+      <!-- email design for desktop -->
       <div v-else class="flex items-center gap-2">
-        <UserAvatar :name="sender.name" size="md" />
-        <span>{{ sender.full_name }}</span>
-        <span>&middot;</span>
+        <span>{{ sender.full_name || "No name found" }}</span>
+        <span class="sm:flex hidden text-sm text-gray-600" v-if="sender.name">{{
+          "<" + sender.name + ">"
+        }}</span>
+      </div>
+
+      <div class="flex gap-0.5 items-center">
         <Tooltip :text="dateFormat(creation, dateTooltipFormat)">
           <div class="text-sm text-gray-600">
             {{ timeAgo(creation) }}
           </div>
         </Tooltip>
-      </div>
-
-      <div class="flex gap-0.5">
         <Button
           variant="ghost"
           class="text-gray-700"
diff --git a/desk/src/components/ticket/TicketAgentActivities.vue b/desk/src/components/ticket/TicketAgentActivities.vue
index a0e31d508..332a74a60 100644
--- a/desk/src/components/ticket/TicketAgentActivities.vue
+++ b/desk/src/components/ticket/TicketAgentActivities.vue
@@ -12,21 +12,24 @@
             :class="[i != activities.length - 1 ? 'after:h-full' : 'after:h-4']"
           >
             <div
-              class="z-10 flex h-7 w-7 items-center justify-center rounded-full bg-gray-100"
+              class="z-10 flex h-7 w-7 items-center justify-center rounded-full bg-white"
               :class="[
-                activity.type === 'history' ? 'bg-white' : 'bg-gray-100',
                 activity.type === 'comment' ? 'mt-0.5' : '',
                 activity.type === 'email' ? 'mt-2' : '',
               ]"
             >
-              <component
-                :is="getActivityIcon(activity.type)"
-                :class="[
-                  activity.type == 'history'
-                    ? 'text-gray-600'
-                    : 'text-gray-800',
-                ]"
+              <Avatar
+                v-if="activity.type === 'email'"
+                size="md"
+                :label="activity.sender?.full_name"
+                :image="getUser(activity.sender?.name).user_image"
+                class="bg-white"
               />
+              <CommentIcon
+                v-else-if="activity.type === 'comment'"
+                class="text-gray-800"
+              />
+              <DotIcon v-else class="text-gray-600" />
             </div>
           </div>
           <div class="mb-4 w-full">
@@ -67,6 +70,7 @@
 </template>
 
 <script setup lang="ts">
+import { Ref, inject, h, computed, onMounted, watch } from "vue";
 import { useElementVisibility } from "@vueuse/core";
 import {
   DotIcon,
@@ -76,10 +80,8 @@ import {
   ActivityIcon,
 } from "@/components/icons";
 import { EmailArea, CommentBox, HistoryBox } from "@/components";
-import { Ref } from "vue";
-import { inject } from "vue";
-import { computed } from "vue";
-import { h } from "vue";
+import { useUserStore } from "@/stores/user";
+import { Avatar } from "frappe-ui";
 
 const props = defineProps({
   activities: {
@@ -94,6 +96,7 @@ const props = defineProps({
 
 const emit = defineEmits(["email:reply", "update"]);
 
+const { getUser } = useUserStore();
 const communicationAreaRef: Ref = inject("communicationArea");
 
 const emptyText = computed(() => {
@@ -116,12 +119,6 @@ const emptyTextIcon = computed(() => {
   return h(icon, { class: "text-gray-500" });
 });
 
-function getActivityIcon(type) {
-  if (type === "email") return EmailAtIcon;
-  else if (type === "comment") return CommentIcon;
-  else return DotIcon;
-}
-
 function scrollToLatestActivity() {
   setTimeout(() => {
     let el;
@@ -137,4 +134,15 @@ function scrollToLatestActivity() {
 defineExpose({
   scrollToLatestActivity,
 });
+
+onMounted(() => {
+  scrollToLatestActivity();
+});
+
+watch(
+  () => props.title,
+  () => {
+    scrollToLatestActivity();
+  }
+);
 </script>
diff --git a/desk/src/components/ticket/TicketAgentContact.vue b/desk/src/components/ticket/TicketAgentContact.vue
index 855d47d44..859c2fee3 100644
--- a/desk/src/components/ticket/TicketAgentContact.vue
+++ b/desk/src/components/ticket/TicketAgentContact.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="flex items-center justify-start gap-5 border-b p-5">
     <Avatar size="3xl" :image="contact.image" :label="contact.name" />
-    <div class="flex items-center justify-between">
+    <div class="flex items-center justify-between flex-1">
       <Tooltip :text="contact.name">
         <div class="w-[242px] truncate text-2xl font-medium">
           {{ contact.name }}

From a855a43ed63edcad31a9d75ff3ad6f602c64724b Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Fri, 25 Oct 2024 12:18:46 +0530
Subject: [PATCH 6/6] fix(styles): email area

---
 desk/src/components/CommentBox.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/desk/src/components/CommentBox.vue b/desk/src/components/CommentBox.vue
index 60f978a8b..0864419b0 100644
--- a/desk/src/components/CommentBox.vue
+++ b/desk/src/components/CommentBox.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="flex-col text-base">
     <div class="mb-1 ml-0.5 flex items-center justify-between">
-      <div class="text-gray-600 flex items-center gap-1">
+      <div class="text-gray-600 flex items-center gap-2">
         <Avatar
           size="sm"
           :label="commenter"
@@ -17,7 +17,7 @@
           </span>
         </p>
       </div>
-      <div class="flex gap-1 items-center">
+      <div class="flex items-center">
         <Tooltip :text="dateFormat(creation, dateTooltipFormat)">
           <span class="pl-0.5 text-sm text-gray-600">
             {{ timeAgo(creation) }}