Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize workaround for UTF-8 encoding in servlet-filters inside liferay-hooks #7

Open
stampedev opened this issue Jan 11, 2016 · 0 comments

Comments

@stampedev
Copy link
Collaborator

hook_securefilter contains a servlet-filter to restrict access to certain URLs that should not be available, if not properly registered as liferay user. However, such servlet-filters break UTF-8 encoding (e.g. of HTTP parameters) if not chained with an encoding-filter inside the hook itself.

It is currently unclear why this happens, because liferay itself contains this filter on container-level (i.e. in Tomcat) and not inside Liferay (i.e. application web.xml). Simply addressing this issue by defining an element in the liferay-hook.xml, referencing the global filter does not work.
This however, is currently fixed, by adding the encoding filter a second time, which is neither efficient and may even lead to other side effects.

Therefore we need some research on how filters are addressed and chained in Liferay and how to optimize our current hook to prevent breaking the encoding without an additional filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant