Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds false return || (edit: update before filing an issue) #75

Closed
NilsWildt opened this issue Oct 22, 2024 · 2 comments
Closed

Adds false return || (edit: update before filing an issue) #75

NilsWildt opened this issue Oct 22, 2024 · 2 comments

Comments

@NilsWildt
Copy link

In

for i in 1:10
        with_logger(logger) do
            @info "metrics" x = x
        end
end

as it becomes:

for i in 1:10
        with_logger(logger) do
            return @info "metrics" x = x
        end
end

It seems that Runic adds a return in front of the @info. I guess it's the with_() do end syntax?

@fredrikekre
Copy link
Owner

Hi, it isn't incorrect: it is the return of the anonymous function created by the do block. However, it became a bit "noisy" so I removed returns from do blocks in #70. You probably just need to update Runic.

@NilsWildt
Copy link
Author

NilsWildt commented Oct 22, 2024

I see -- and indeed, had to update. Didn't think of my shared @ runic where it ran!
Thank you.

@NilsWildt NilsWildt changed the title Adds false return Adds false return || (edit: update before filing an issue) Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants