You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it be possible to update the current FSharp.Core 4.7.1 to 6.0.1, and update F# language version to 6.0 ?
Or is there still really justification to support F# core 4.7.1 ?
This is nothing to do with .NET Framework support, which I still would like to keep as is: .Net Standard 2.0 and .Net Standard 2.1.
I was testing the performance, and seems the CodeGenerator is bit slow,
and making the current active patterns to Structs would actually help quite a bit:
letmakeTypePattern tp =lettt= convTypeToTgt tp
fun(t: Type)->if t = tt then ValueSome()else ValueNone
[<return: Struct>]let(|Bool|_|)= makeTypePattern(typeof<bool>)[<return: Struct>]let(|SByte|_|)= makeTypePattern(typeof<sbyte>)[<return: Struct>]let(|Int16|_|)= makeTypePattern(typeof<int16>)[<return: Struct>]let(|Int32|_|)= makeTypePattern(typeof<int32>)[<return: Struct>]let(|Int64|_|)= makeTypePattern(typeof<int64>)[<return: Struct>]let(|Byte|_|)= makeTypePattern(typeof<byte>)[<return: Struct>]let(|UInt16|_|)= makeTypePattern(typeof<uint16>)[<return: Struct>]let(|UInt32|_|)= makeTypePattern(typeof<uint32>)[<return: Struct>]let(|UInt64|_|)= makeTypePattern(typeof<uint64>)[<return: Struct>]let(|Single|_|)= makeTypePattern(typeof<single>)[<return: Struct>]let(|Double|_|)= makeTypePattern(typeof<double>)[<return: Struct>]let(|Char|_|)= makeTypePattern(typeof<char>)[<return: Struct>]let(|Decimal|_|)= makeTypePattern(typeof<decimal>)[<return: Struct>]let(|String|_|)= makeTypePattern(typeof<string>)//... and (|NaN|_|) and (|NaNSingle|_|) could also be struct-tuples
The other option would be adding more compiler directives, because most of the F# TypeProviders refer this still as external file and not Nuget-package. So would you rather accept something like #if FSHARP6 code-block PR?
The text was updated successfully, but these errors were encountered:
Would it be possible to update the current FSharp.Core 4.7.1 to 6.0.1, and update F# language version to 6.0 ?
Or is there still really justification to support F# core 4.7.1 ?
This is nothing to do with .NET Framework support, which I still would like to keep as is: .Net Standard 2.0 and .Net Standard 2.1.
I was testing the performance, and seems the CodeGenerator is bit slow,
and making the current active patterns to Structs would actually help quite a bit:
FSharp.TypeProviders.SDK/src/ProvidedTypes.fs
Line 14047 in 3a9510e
The other option would be adding more compiler directives, because most of the F# TypeProviders refer this still as external file and not Nuget-package. So would you rather accept something like
#if FSHARP6
code-block PR?The text was updated successfully, but these errors were encountered: