Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-rotate / Orientation issues #1260

Closed
1 of 3 tasks
Giesa-lab opened this issue Aug 23, 2024 · 5 comments
Closed
1 of 3 tasks

Auto-rotate / Orientation issues #1260

Giesa-lab opened this issue Aug 23, 2024 · 5 comments
Labels
All Bug Something isn't working Duplicate This issue or pull request already exists

Comments

@Giesa-lab
Copy link

Giesa-lab commented Aug 23, 2024

What happened?

After reading all the various bugs and issues that folks are having, with auto-rotate settings, it seems clear to me that they can All be solved with the addition of TWO extra options in the settings menu for this item. IMHO GrayJay is trying to be too clever in this regard.

So, the current options are.... 1. Disabled 2. Enabled 3. Same as System

For various reasons, many people are having trouble with this setting, and the Auto-rotate Dead Zone setting. By adding the following 2 options, I believe that this is what most people are really looking for in the behaviour. The original options can stay too.

So, please add options... 4. Always Portrait 5. Always Landscape

The coders can fix the other reported issues at their leisure, while phone users can do option 4, and tablet users do option 5.

Also, this setting should apply to the behaviour of the entire App, and Not just the Player. This way, EVERY menu/listing/player can appear in a user's preferred orientation. Those who don't experience any issues, can use the original options.

Like/comment on my post if you agree !

Grayjay Version

249

What plugins are you seeing the problem on?

All

Plugin Version

N/A

When do you experience the issue?

  • While logged in
  • While logged out
  • N/A

Relevant log output

N/A
@github-actions github-actions bot added the All label Aug 23, 2024
@codebymatter
Copy link

codebymatter commented Aug 30, 2024

I have auto-rotate set to Same As System. So no auto-relating bc it can get annoying on commutes. I just discovered the swipe up to go landscape and swipe down to go back to portrait gestures.

And I thought my phone had a sensitivity issue. I like the gestures so I don't have to smear my phone's screen with my greasy hands on lunchbreak or struggle a bit to hit Square instead of play-finder.

@xephos1one
Copy link

Related to #67
The rotation issue should be fixed in the upcoming version

@Giesa-lab
Copy link
Author

@xephos1one and everybody...
With new version 259 release this issue is VERY MUCH WORSE !!!
Auto-rotate ...
"Same as System"
DOES NOT FOLLOW SYSTEM SETTINGS !

Bypass Rotation Prevention
"This may cause unexpected behaviour, and is mostly untested."
Unexpected behaviour yes, and Now it does NOT Rotate at all in any mode EXCEPT in Full screen Player !

This maybe is "mostly untested" by developers, but I can assure them; This IS "Extensively Tested" by the users, and it DOES NOT work at all anymore... 🙄☹️

@Giesa-lab
Copy link
Author

Giesa-lab commented Sep 9, 2024

@xephos1one @codebymatter and everybody

With V262 the rotation issue is FIXED, so far as "Same As System" option is concerned, and now every menu does follow system settings on Android 9+ , and will show as Landscape, with the exception of the settings menu, which still displays only in Portrait mode, no matter which setting is chosen. Maybe this is enough to satisfy, all but the most critical of users? What do other users think, is this good enough? 🤔👍

@Zvonimir-FUTO Zvonimir-FUTO added Bug Something isn't working Duplicate This issue or pull request already exists labels Sep 22, 2024
@Zvonimir-FUTO
Copy link
Collaborator

Will be solved through #67

@Zvonimir-FUTO Zvonimir-FUTO closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
All Bug Something isn't working Duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants