Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation lock bug #1331

Closed
1 of 3 tasks
mingyee2 opened this issue Sep 11, 2024 · 6 comments
Closed
1 of 3 tasks

Rotation lock bug #1331

mingyee2 opened this issue Sep 11, 2024 · 6 comments
Labels
Awaiting Info Bug Something isn't working Rotation

Comments

@mingyee2
Copy link

What happened?

Simply put, once fullscreened, I expect the rotation lock button to keep the rotation locked. Instead, no matter which state the button is in, the video rotates as the orientation of my phone changes. I have tested that this occurs regardless of system setting for rotation lock.

Grayjay Version

264

What plugins are you seeing the problem on?

All

Plugin Version

No response

When do you experience the issue?

  • While logged in
  • While logged out
  • N/A

Relevant log output

No response

@github-actions github-actions bot added the All label Sep 11, 2024
@mingyee2
Copy link
Author

In the update before this one, if locked on landscape, exiting fullscreen would put the app and video in portrait (as expected, probably), but putting it back in fullscreen would put it in portrait (different behaviour than for the past year). This was if the phone was oriented in landscape. If, however, the phone was oriented upside-down (landscape for when I am watching sideways in bed), exiting fullscreen would put the app and video in landscape (I think the app is meant to never be in landscape unfullscreened?), but re-entering fullscreen would properly put the video in landscape.

@codebymatter
Copy link

codebymatter commented Sep 11, 2024

Enable Full-Auto Rotation Lock to keep the fullscreen view fixed to 90° landscape (as in landscspe with cameras on left and USB-C port on the right)

I noticed the rotation lock icon while watching videos but seems to do notbing. When tapped and is unlocked and tapped again to lock, nada. I have System Rotation Off and Rotation in-app set to Same as System.

It's not an issue for me as I want the fullscreen landscape to rotate to 270° or stay in 90^. The 3.5mm jack is positioned left of the USB-C so I have to rotate my phone and all good.

@mingyee2
Copy link
Author

Thanks. That did indeed return behaviour to something usable.

Nevertheless, with the setting off, I believe the behaviour is bugged, since I think that setting is only supposed to govern landscape to reverse landscape and vice versa, not landscape to portrait, etc.

@itsvrl
Copy link

itsvrl commented Sep 13, 2024

Also bugged on GrapheneOS. Every other app I have on the phone works normally, only the grayjay app that have this behavior. To fix it I must hard shutdown the app and launch the app again.

Version code: 264
Version name: 264

@support-grayjay support-grayjay added Bug Something isn't working Rotation and removed All labels Nov 3, 2024
@Zvonimir-FUTO
Copy link
Collaborator

Is this still present in the latest (v264) version of Grayjay and did you enabled "Allow reverse portrait" by chance?

@mingyee2
Copy link
Author

mingyee2 commented Nov 30, 2024

I just tested, and it appears to be fixed, yes. With #1332 closed by the upcoming version, that should be all the rotation behaviour on my wishlist :). Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Info Bug Something isn't working Rotation
Projects
None yet
Development

No branches or pull requests

5 participants