Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Synchronize Watch Later between Devices #1630

Open
SCBionicle opened this issue Dec 19, 2024 · 8 comments
Open

[Bug] Synchronize Watch Later between Devices #1630

SCBionicle opened this issue Dec 19, 2024 · 8 comments
Labels
Bug Something isn't working Sync

Comments

@SCBionicle
Copy link

Use Cases

There's a lot of videos that I end up wanting to watch and I find it really handy to bookmark the videos in the watch later playlist, especially since the watch later playlist automatically clears when you watch the video.

Proposal

I will switch between my desktop and phone to watch videos. Since the desktop just released into open alpha, it would be very handy to the synchronization feature synchronize the watch later list between devices.

References

No response

@Zvonimir-FUTO Zvonimir-FUTO added Enhancement New feature or request Sync labels Dec 19, 2024
@Zvonimir-FUTO
Copy link
Collaborator

Hey Seth, that should already be synced but the view doesn't refresh immediately. Can you try opening different tabs or closing and opening the app to see if the change was made?

@SCBionicle
Copy link
Author

I'll take another look when I get home from work, and I'll post an update.

@SCBionicle
Copy link
Author

So, it does sync somewhat. It goes back and forth with adding to the watch later list on desktop, only if I have already created a watch later list on desktop.

It does not, however, download my already existing items in my watch later list from my phone to my desktop prior to me creating a watch later list on the desktop.

This may be a bug.

@SCBionicle
Copy link
Author

It would be difficult to test if the sync will retroactively add and remove items from a playlist after the devices reconnect from being disconnected.

@Paeniche
Copy link

Paeniche commented Dec 20, 2024

I've had intermittent success with "watch later" syncing. Watch later occasionally syncs, but when it stops syncing I consistently see this error when opening Grayjay on my phone(GrapheneOS, Pixel6a). Terminal log is from my desktop (Fedora 41, Plasma) and I removed the session id and public key.

HandshakeAsResponder: Read message size 96
HandshakeAsResponder: Wrote message size 48
T:Handshake complete with (LocalPublicKey = , RemotePublicKey = )
T:Sent AUTHORIZED with session id 
T:onAuthorized (isNewlyAuthorized = False, isNewSession = True)
T:public key authorized
StateSync:New session 
Failed to run as responder: System.IO.IOException: Unable to write data to the transport connection: Broken pipe.
 ---> System.Net.Sockets.SocketException (32): Broken pipe
   at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 count)
   --- End of inner exception stack trace ---
   at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 count)
   at Grayjay.ClientServer.Sync.Internal.SyncSocketSession.Send(Byte opcode, Byte subOpcode, ReadOnlySpan`1 data)
   at Grayjay.ClientServer.Sync.Internal.SyncSession.Send(Byte opcode, Byte subOpcode, Byte[] data)
   at Grayjay.ClientServer.Sync.Internal.SyncSession.SendJsonData(Byte subOpcode, Object data)
   at Grayjay.ClientServer.States.StateSync.CheckForSync(SyncSession session)
   at Grayjay.ClientServer.States.StateSync.<>c__DisplayClass36_1.<CreateSocketSession>b__3(SyncSession sess, Boolean isNewlyAuthorized, Boolean isNewSession)
   at Grayjay.ClientServer.Sync.Internal.SyncSession.CheckAuthorized()
   at Grayjay.ClientServer.Sync.Internal.SyncSession.Authorize(SyncSocketSession socketSession)
   at Grayjay.ClientServer.States.StateSync.<>c__DisplayClass36_0.<CreateSocketSession>b__1(SyncSocketSession s)
   at Grayjay.ClientServer.Sync.Internal.SyncSocketSession.<StartAsResponder>b__34_0()
Session closed

@SCBionicle SCBionicle changed the title [Feature Request] Synchronize Watch Later between Devices [Feature Request/Bug?] Synchronize Watch Later between Devices Dec 20, 2024
@Zvonimir-FUTO Zvonimir-FUTO added Bug Something isn't working and removed Enhancement New feature or request labels Dec 20, 2024
@SCBionicle SCBionicle changed the title [Feature Request/Bug?] Synchronize Watch Later between Devices [Bug] Synchronize Watch Later between Devices Dec 20, 2024
@SCBionicle
Copy link
Author

Hmm? What's this?

image

Why am I being billed with this?

@SCBionicle
Copy link
Author

SCBionicle commented Dec 23, 2024

Btw, observed behavior is that new (not existing) entries sync fine to desktop if the devices are actively connected, but do not retroactively update if the changes were when they were disconnected.

I have not paid enough attention to know for sure if the syncing works fine the other way.

@Zvonimir-FUTO
Copy link
Collaborator

Hmm? What's this?

Why am I being billed with this?

You are not being billed for this but for a weird reason you got emailed for triggering the job for a labeler and we ran out of the worker minutes. Anyway, we removed it since it not that useful and we don't you getting those kind of emails. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Sync
Projects
None yet
Development

No branches or pull requests

3 participants