From 9703b8314f33ff9e5e07923e18a9b655c9bb8469 Mon Sep 17 00:00:00 2001 From: futpib Date: Sat, 17 Jan 2015 13:55:41 +0300 Subject: [PATCH] Allow system principal and "modify request"-hooked by default Since having them disabled breaks not only addons but even some of firefox features. This was the behavior before introduction of "http-on-modify-request" hook anyway. close #148 --- src/defaults/rulesets/compatibility.ruleset | 15 --------------- src/defaults/rulesets/default.ruleset | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/defaults/rulesets/compatibility.ruleset b/src/defaults/rulesets/compatibility.ruleset index 72bb6e2..c073346 100644 --- a/src/defaults/rulesets/compatibility.ruleset +++ b/src/defaults/rulesets/compatibility.ruleset @@ -57,18 +57,3 @@ rules: # like magnet, irc, webcal, custombutton, etc # by allowing any documents from such schemes. [contentType] DOCUMENT: ACCEPT - - * -> *: - # Allows requests having system principal - # TODO A lot of addons seem to be using nsIHTTPChannel and for now this is - # the most obvious way not to break them. But this also allows favicon and - # google safebrowsing (and maybe more) requests that may be unwanted by - # user. This is hopefully a temporary solution until a good way of dealing - # with such requests is developed - [specialPrincipal] system: ACCEPT - - * -> *: - # Allows requests hooked by "http-on-modify-request" observer - # TODO Highly related to the above todo, this effectively makes the observer - # hook useless. Temporary solution, hopefully. - [hook] modifyRequest: ACCEPT diff --git a/src/defaults/rulesets/default.ruleset b/src/defaults/rulesets/default.ruleset index c1e3de9..55ddcbc 100644 --- a/src/defaults/rulesets/default.ruleset +++ b/src/defaults/rulesets/default.ruleset @@ -40,3 +40,18 @@ rules: (web|file) -> internal: # top-level media player and image viewer require internal styles [contentType] STYLESHEET: ACCEPT + + * -> *: + # Allows requests having system principal + # TODO A lot of addons seem to be using nsIHTTPChannel and for now this is + # the most obvious way not to break them. But this also allows favicon and + # google safebrowsing (and maybe more) requests that may be unwanted by + # user. This is hopefully a temporary solution until a good way of dealing + # with such requests is developed + [specialPrincipal] system: ACCEPT + + * -> *: + # Allows requests hooked by "http-on-modify-request" observer + # TODO Highly related to the above todo, this effectively makes the observer + # hook useless (except for requests mangled by lib/request-info). + [hook] modifyRequest: ACCEPT