Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for Cat-VRS data classes #87

Open
DanielPuthawala opened this issue Dec 5, 2024 · 5 comments
Open

Add examples for Cat-VRS data classes #87

DanielPuthawala opened this issue Dec 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@DanielPuthawala
Copy link
Collaborator

It was expressed at the last Cat-VRS call that having examples alongside the schemata and docs really helped people new to the project to orient themselves. It was requested that we add additional examples (2 or 3 per class?) that demosntrate different aspects of the schemas.

@DanielPuthawala DanielPuthawala added enhancement New feature or request help wanted Extra attention is needed labels Dec 5, 2024
@brendanreardon
Copy link
Collaborator

brendanreardon commented Dec 12, 2024

A non-exhaustive list of example updates that we want to make:

@brendanreardon
Copy link
Collaborator

I just noticed that this thread may be a duplicate of #25. Should we close this in favor of the earlier one from Kori?

@korikuzma
Copy link
Contributor

I can close mine!

@brendanreardon
Copy link
Collaborator

brendanreardon commented Dec 17, 2024

I committed hgvs representations to proteinSequenceConsequence-ex1.yaml. Some questions and comments that I have about the examples are...

  • What do people think about not using the shorthand of vrs.json#ga4gh:VA.... for DefiningAlleleConstraint and members? I understand that this is quicker, but since it requires vrs-python to be set up locally to get unhash the id, it may add to confusion as new implementers are trying to get initiated.
  • In the hgvs list extension for canonicalAllele-ex1.yaml, the first nucleotideExpression has "top-level" for the nucleotideType. What does this mean? I couldn't find anything about this in either the va-spec, vrs, or gks documentation either.
  • As an aside, even though the extension field is unstructured, it may be nice to have documentation of why the examples are structured as they are. Regardless of how much documentation is written, in practice the examples are going to serve as templates for the community.
  • All current examples using either DefiningAlleleConstraint or DefiningLocationConstraint list relations within the constraint. As a mappable concept, they should list more than just the primaryCode. Similar to above, it would be nice to have definitions for the primaryCodes being used in the current examples.
  • Since the examples are written in .yaml, how do people feel about adding comments within the files? Specifically to link to relevant documentation for each section of an example. Alternatively, if folks are worried about cluttering the examples, we can add a README.md (or .rst) to the examples folder.

@jsstevenson
Copy link
Contributor

jsstevenson commented Dec 17, 2024

What do people think about not using the shorthand of vrs.json#ga4gh:VA.... for DefiningAlleleConstraint and members? I understand that this is quicker, but since it requires vrs-python to be set up locally to get unhash the id, it may add to confusion as new implementers are trying to get initiated.

We really should have a simple web app for this (generating variation object/hash)

@brendanreardon brendanreardon moved this from Todo to Needs Review in Cat-VRS Dec 18, 2024
@brendanreardon brendanreardon moved this from Needs Review to In Progress in Cat-VRS Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

4 participants