Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to use custom payload renderer for Pusher. #92

Open
rthideaway opened this issue Mar 22, 2017 · 6 comments
Open

Provide a way to use custom payload renderer for Pusher. #92

rthideaway opened this issue Mar 22, 2017 · 6 comments

Comments

@rthideaway
Copy link

I was told that this is the main liveblog issue tracker so posting here as well. Details about issue were already described here https://www.drupal.org/node/2862789

@tjwelde
Copy link
Contributor

tjwelde commented Mar 22, 2017

Yes, thanks. With this project, we are using a github workflow.
I think it's a good idea and I will look into it. Could you make a Pull Request and reference this issue?

@tjwelde
Copy link
Contributor

tjwelde commented Mar 22, 2017

Btw, if there are other problems with embedding this into headless sites, please open some issues here.

@rthideaway
Copy link
Author

PR created. And thanks, I'll come back if something pops up, but for now we're fine, thanks!

@maosmurf
Copy link
Collaborator

patch from https://www.drupal.org/files/issues/2862789-9.patch is not applicable anymore, will look into this issue for 1.2.0-alpha13 and drupal 8.4

@maosmurf
Copy link
Collaborator

Patch 2862789-13.patch for alpha13 https://www.drupal.org/files/issues/2862789-13.patch

We still need to find a solution to provide custom renderers, as we push only json to pusher and decoupled frontend takes care of rendering to client.

@milkovsky
Copy link
Collaborator

Agree, I think it makes also sense to have a pluggable render service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants