Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad quality of presentation with --fullscreen flag #15

Open
torannn opened this issue Jul 9, 2021 · 5 comments
Open

Bad quality of presentation with --fullscreen flag #15

torannn opened this issue Jul 9, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@torannn
Copy link

torannn commented Jul 9, 2021

image
I did a comparison about the quality of manim presentation with the --fullscreen flag. In the first picture, I rendererd a manim scene with manim -qh example.py and then ran it with manim_presentation --fullscreen example. As we can see in the 1st picture, the quality is not so high (it's bad as low-quality rendering).

Then, I tried running without --fullscreen, the quality of the scene turn back to high quality (but lost the ability to be fullscreen).
Seems like when doing the full-screen, the presentation has been scaled down to fit the screen, and cause this bad quality.
image

Is there any way to fix this?

@galatolofederico
Copy link
Owner

Hi, currently manim presentation is using @glatteis full screen implementation. I was trying to have a real full screen working but is more challenging that it seems. As soon as i will have some spare time i'll try to fix this

@galatolofederico galatolofederico added the bug Something isn't working label Jul 9, 2021
@jeertmans
Copy link

Hello ! I managed to fix this issue on Windows. On Linux, the quality never downgraded with --fullscreen flag.
Maybe I can propose a PR?

@AnonymoZ
Copy link

@jeertmans Please do!! And on windows if you can! 🙏
It's such a bummer this bug!

@jeertmans
Copy link

@AnonymoZ I already have a fix that also work on Windows, I am planning to have it pushed by the next three weeks.
Due to the seemingly inactivity of this repo, I decided to work on my own fork, on which I plan to commit this fix as well as others.
See here.

@galatolofederico
Copy link
Owner

Hey @AnonymoZ @jeertmans unfortunately i do not have windows nor access to a windows computer to debug this issue. If you open a PR i will be happy to merge your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants